Merge lp:~openerp-dev/openobject-addons/trunk-opw-580469-port-mma into lp:openobject-addons

Proposed by Mayur Maheshwari(OpenERP)
Status: Rejected
Rejected by: Fabien (Open ERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-opw-580469-port-mma
Merge into: lp:openobject-addons
Diff against target: 12 lines (+2/-0)
1 file modified
account/account_move_line.py (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-opw-580469-port-mma
Reviewer Review Type Date Requested Status
Fabien (Open ERP) Disapprove
Review via email: mp+136333@code.launchpad.net

Description of the change

Hello,

 I have fixed the issue of allowing write the journal items of closed periods.
 code is forward port from 6.1

Thanks,
Mayur

To post a comment you must log in.
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

you should always be able to edit non accounting fields (like; notes) so I don't think this fix is good.

review: Disapprove

Unmerged revisions

8142. By Hardik Ansodariya (OpenERP)

[FIX]account: Fixed the issue of writing journal items of closed period

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_move_line.py'
2--- account/account_move_line.py 2012-11-26 18:28:11 +0000
3+++ account/account_move_line.py 2012-11-27 07:32:24 +0000
4@@ -1187,6 +1187,8 @@
5 if check:
6 done = []
7 for line in self.browse(cr, uid, ids):
8+ if line.period_id.state == 'done':
9+ raise osv.except_osv(_('Unable to change Journal Items'), _('You can not change the journal items of closed period'))
10 if line.move_id.id not in done:
11 done.append(line.move_id.id)
12 move_obj.validate(cr, uid, [line.move_id.id], context)

Subscribers

People subscribed via source and target branches

to all changes: