Merge lp:~openerp-dev/openobject-addons/trunk-opw-580329-port-mma into lp:openobject-addons

Proposed by Mayur Maheshwari(OpenERP)
Status: Rejected
Rejected by: Fabien (Open ERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-opw-580329-port-mma
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
hr_attendance/wizard/hr_attendance_bymonth_view.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-opw-580329-port-mma
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+135066@code.launchpad.net

Description of the change

Hello,

        I have Fixed the usability issue in year field of view_hr_attendance_month wizard, field is integer and displaying year so set widget=char otherwise thousand and decimal separator will applied on year.

     steps :- Human Resources -> Employee -> Attendance by Month, here you can see year value is thousand separated.

    code is forward port from 6.1

Thanks.
Mayur

To post a comment you must log in.
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

rejected as you do not handle the case where the user will write a non number in the field.

Unmerged revisions

8076. By Mohammed Shekha(Open ERP)

[FIX]hr_attendance: Fixed the usability issue in year field of view_hr_attendance_month wizard, field is integer and displaying year so set widget=char otherwise thousand and decimal seperator will applied on year.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_attendance/wizard/hr_attendance_bymonth_view.xml'
2--- hr_attendance/wizard/hr_attendance_bymonth_view.xml 2012-08-08 12:48:39 +0000
3+++ hr_attendance/wizard/hr_attendance_bymonth_view.xml 2012-11-20 06:33:38 +0000
4@@ -9,7 +9,7 @@
5 <form string="Print Attendance Report Monthly" version="7.0">
6 <group col="4">
7 <field name="month"/>
8- <field name="year"/>
9+ <field name="year" widget="char"/>
10 </group>
11 <footer>
12 <button name="print_report" string="Print" type="object" class="oe_highlight"/>

Subscribers

People subscribed via source and target branches

to all changes: