Merge lp:~openerp-dev/openobject-addons/trunk-opw-578009-port-mma into lp:openobject-addons

Proposed by Mayur Maheshwari(OpenERP)
Status: Merged
Merged at revision: 8001
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-opw-578009-port-mma
Merge into: lp:openobject-addons
Diff against target: 21 lines (+2/-2)
1 file modified
sale/sale.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-opw-578009-port-mma
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Review via email: mp+132543@code.launchpad.net

Description of the change

Hello,

Notes field of sale order lines is not being translated in customer's language.

This fixes the issue.
Code is forward port from 6.1

Thanks,
Mayur

To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Obviously this patch was not tested, as product_obj is reused after being redefined as a browse_record - so the name_get calls will always fail. Please at least test your patches before creating merge proposals -- especially here as it seems you added an extra change to the original patch for 6.1.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale/sale.py'
2--- sale/sale.py 2012-10-26 15:34:36 +0000
3+++ sale/sale.py 2012-11-01 13:02:28 +0000
4@@ -903,7 +903,7 @@
5
6 result = {}
7 warning_msgs = {}
8- product_obj = product_obj.browse(cr, uid, product, context=context)
9+ product_obj = product_obj.browse(cr, uid, product, context=context_partner)
10
11 uom2 = False
12 if uom:
13@@ -922,7 +922,7 @@
14 result['tax_id'] = self.pool.get('account.fiscal.position').map_tax(cr, uid, fpos, product_obj.taxes_id)
15
16 if not flag:
17- result['name'] = self.pool.get('product.product').name_get(cr, uid, [product_obj.id], context=context_partner)[0][1]
18+ result['name'] = product_obj.name_get(cr, uid, [product_obj.id], context=context_partner)[0][1]
19 if product_obj.description_sale:
20 result['name'] += '\n'+product_obj.description_sale
21 domain = {}

Subscribers

People subscribed via source and target branches

to all changes: