Merge lp:~openerp-dev/openobject-addons/trunk-opw-577224-port-mma into lp:openobject-addons

Proposed by Mayur Maheshwari(OpenERP)
Status: Superseded
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-opw-577224-port-mma
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
sale/report/sale_report.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-opw-577224-port-mma
Reviewer Review Type Date Requested Status
Fabien (Open ERP) Disapprove
Review via email: mp+135861@code.launchpad.net

This proposal has been superseded by a proposal from 2012-12-19.

Description of the change

Hello,

  I have Fixed the issue of currency conversion in sales analysis report.
  sales with different currency but in sale analysis report Total price should be convert with
  Base currency of company.
  e.g
     create a sale order with GBP, USD and EUR(Price lsit) in order line it will convert properly according to currency rate with base currency.But in sales analysis report it is not converting Total price with base currency.

   code is forward port from 6.1

Thanks,
Mayur

To post a comment you must log in.
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

invalid fix, you must use the price from the SO, not the product (eventually with a currency conversion)

review: Disapprove
8106. By Mayur Maheshwari(OpenERP)

[IMP]sale: use unit price on so with a currency conversion to fix total price was not reflecting in currency conversion

Unmerged revisions

8106. By Mayur Maheshwari(OpenERP)

[IMP]sale: use unit price on so with a currency conversion to fix total price was not reflecting in currency conversion

8105. By Hardik Ansodariya (OpenERP)

[FIX]sale_report: Total price was not reflecting in currency conversion

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale/report/sale_report.py'
2--- sale/report/sale_report.py 2012-10-12 11:42:58 +0000
3+++ sale/report/sale_report.py 2012-11-23 10:46:22 +0000
4@@ -70,7 +70,7 @@
5 l.product_id as product_id,
6 t.uom_id as product_uom,
7 sum(l.product_uom_qty / u.factor * u2.factor) as product_uom_qty,
8- sum(l.product_uom_qty * l.price_unit * (100.0-l.discount) / 100.0) as price_total,
9+ sum(l.product_uom_qty * t.list_price * (100.0-l.discount) / 100.0) as price_total,
10 1 as nbr,
11 s.date_order as date,
12 s.date_confirm as date_confirm,

Subscribers

People subscribed via source and target branches

to all changes: