Merge lp:~openerp-dev/openobject-addons/trunk-opw-576863-port-mma into lp:openobject-addons

Proposed by Mayur Maheshwari(OpenERP)
Status: Merged
Merged at revision: 8324
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-opw-576863-port-mma
Merge into: lp:openobject-addons
Diff against target: 15 lines (+2/-1)
1 file modified
base_report_designer/plugin/openerp_report_designer/bin/script/SendToServer.py (+2/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-opw-576863-port-mma
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+135350@code.launchpad.net

Description of the change

Hello,

Using OpenERP plugin for OpenOffice, the 'Send to the server' functionality doesn't show the report at destination model if used by user other then Administrator(uid=1).

Steps to Reproduce issue:
1) Create a DB and install base_report_designer module,
2) Configure report_designer_plugin.zip for OpenOffice,
3) Create a user and give him all access as Administrator has,
4) Logged in with this user and create a OpenOffice report, and upload it to destination model in server using 'Send to the server',
5) In OpenERP client, go to destination model and you will not find the uploaded report.

Note: You will notice message, "Operation prohibited by access rules, or performed on an already deleted document (Operation: create, Document type: ir.values)."

The cause of the issue is, plugin sends data with 'key': 'action' and no user information for 'user_id' field of 'ir.values' model and the access rules(orm's def check_access_rule(...)) checks for 'key'='default' and 'user_id'=<current logged in user> which forces the check_access_rule(...) to raise this warning.

I have fixed this issue and this fix is dependent on another fix at branch:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-opw-576863-port-mma

code is forward port from 6.1

Thanks,
Mayur

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_report_designer/plugin/openerp_report_designer.zip'
2Binary files base_report_designer/plugin/openerp_report_designer.zip 2011-06-17 14:10:24 +0000 and base_report_designer/plugin/openerp_report_designer.zip 2012-11-21 10:11:37 +0000 differ
3=== modified file 'base_report_designer/plugin/openerp_report_designer/bin/script/SendToServer.py'
4--- base_report_designer/plugin/openerp_report_designer/bin/script/SendToServer.py 2012-10-02 10:29:15 +0000
5+++ base_report_designer/plugin/openerp_report_designer/bin/script/SendToServer.py 2012-11-21 10:11:37 +0000
6@@ -166,7 +166,8 @@
7 'model': docinfo.getUserFieldValue(3),
8 'value': 'ir.actions.report.xml,'+str(id),
9 'key2': 'client_print_multi',
10- 'object': True
11+ 'object': True,
12+ 'user_id': uid
13 }
14 res = self.sock.execute(database, uid, self.password, 'ir.values' , 'create',rec )
15 else :

Subscribers

People subscribed via source and target branches

to all changes: