Merge lp:~openerp-dev/openobject-addons/trunk-improve_send_mail into lp:openobject-addons

Proposed by Vishmita Jadeja (openerp)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-improve_send_mail
Merge into: lp:openobject-addons
Diff against target: 30 lines (+13/-0)
1 file modified
mail/wizard/mail_compose_message.py (+13/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-improve_send_mail
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+152091@code.launchpad.net

Description of the change

Hello,

      if you try to send email using an invalid smtp sever,it should give you notification.

Thanks

To post a comment you must log in.
8594. By Vishmita Jadeja (openerp)

[Merge]Merge with Trunk

8595. By Vishmita Jadeja (openerp)

[Merge]Merge with Trunk

8596. By Amit Bhavsar (Open ERP)

[MERGE] merge with latest trunk

8597. By Foram Katharotiya (OpenERP)

[MERGE] with trunk

Unmerged revisions

8597. By Foram Katharotiya (OpenERP)

[MERGE] with trunk

8596. By Amit Bhavsar (Open ERP)

[MERGE] merge with latest trunk

8595. By Vishmita Jadeja (openerp)

[Merge]Merge with Trunk

8594. By Vishmita Jadeja (openerp)

[Merge]Merge with Trunk

8593. By Vishmita Jadeja (openerp)

[Imp]Improve Code

8592. By Vishmita Jadeja (openerp)

[IMP]Notification when the mail fails to be sent

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mail/wizard/mail_compose_message.py'
2--- mail/wizard/mail_compose_message.py 2013-05-29 09:59:00 +0000
3+++ mail/wizard/mail_compose_message.py 2013-06-13 06:51:27 +0000
4@@ -219,6 +219,18 @@
5 }
6 return result
7
8+ def _check_smtp_server(self, cr, uid, ids,context=None):
9+ """check smtp configured or not"""
10+ ir_mail_server = self.pool.get('ir.mail_server')
11+ mail_connection = ir_mail_server.search(cr, uid, [], order='sequence', limit=1)
12+ smtp_server = ir_mail_server.browse(cr, uid, mail_connection, context=context)[0]
13+ try:
14+ connection = ir_mail_server.connect(smtp_server.smtp_host, smtp_server.smtp_port, user=smtp_server.smtp_user,
15+ password=smtp_server.smtp_pass, encryption=smtp_server.smtp_encryption,
16+ smtp_debug=smtp_server.smtp_debug)
17+ except:
18+ raise self.pool.get('res.config.settings').get_config_warning(cr, _("Cannot send email: no outgoing email server configured.\nYou can configure it under %(menu:base.menu_mail_servers)s."), context)
19+ return True
20 #------------------------------------------------------
21 # Wizard validation and send
22 #------------------------------------------------------
23@@ -232,6 +244,7 @@
24 active_ids = context.get('active_ids')
25 is_log = context.get('mail_compose_log', False)
26
27+ self._check_smtp_server(cr, uid, ids, context)
28 for wizard in self.browse(cr, uid, ids, context=context):
29 mass_mail_mode = wizard.composition_mode == 'mass_mail'
30 active_model_pool = self.pool[wizard.model if wizard.model else 'mail.thread']

Subscribers

People subscribed via source and target branches

to all changes: