Merge lp:~openerp-dev/openobject-addons/trunk-imp-register_hook_improved-cto into lp:openobject-addons

Proposed by Samus CTO (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-imp-register_hook_improved-cto
Merge into: lp:openobject-addons
Diff against target: 29 lines (+3/-3)
1 file modified
base_action_rule/base_action_rule.py (+3/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-imp-register_hook_improved-cto
Reviewer Review Type Date Requested Status
Christophe Simonis (OpenERP) Pending
Review via email: mp+206924@code.launchpad.net

Description of the change

Hello,

Here is a fix for the missing commit after calling _register_hook and also I added the update_module parameter which is very useful to know after having loaded a pool and can't be guessed with the tools.config because this variable is reset before the call of _register_hook.

This branch is related: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-imp-register_hook_improved-cto/+merge/206923

Thanks

To post a comment you must log in.
9087. By Niko (OpenERP)

[IMP] Add some video to manisfest ( website, website_blog, website_event, website_ecommerce)

Unmerged revisions

9156. By Samus CTO (OpenERP)

[IMP] after all _register_hook calls, the cursor is committed + added the update_module flag in argument of the call because it can be useful

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_action_rule/base_action_rule.py'
2--- base_action_rule/base_action_rule.py 2014-01-10 12:49:28 +0000
3+++ base_action_rule/base_action_rule.py 2014-02-18 12:52:03 +0000
4@@ -210,7 +210,7 @@
5
6 return write
7
8- def _register_hook(self, cr, ids=None):
9+ def _register_hook(self, cr, update_module, ids=None):
10 """ Wrap the methods `create` and `write` of the models specified by
11 the rules given by `ids` (or all existing rules if `ids` is `None`.)
12 """
13@@ -227,7 +227,7 @@
14
15 def create(self, cr, uid, vals, context=None):
16 res_id = super(base_action_rule, self).create(cr, uid, vals, context=context)
17- self._register_hook(cr, [res_id])
18+ self._register_hook(cr, False, ids=[res_id])
19 openerp.modules.registry.RegistryManager.signal_registry_change(cr.dbname)
20 return res_id
21
22@@ -235,7 +235,7 @@
23 if isinstance(ids, (int, long)):
24 ids = [ids]
25 super(base_action_rule, self).write(cr, uid, ids, vals, context=context)
26- self._register_hook(cr, ids)
27+ self._register_hook(cr, False, ids=ids)
28 openerp.modules.registry.RegistryManager.signal_registry_change(cr.dbname)
29 return True
30

Subscribers

People subscribed via source and target branches

to all changes: