Merge lp:~openerp-dev/openobject-addons/trunk-home-action-rga into lp:openobject-addons

Proposed by Ravi Gadhia (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-home-action-rga
Merge into: lp:openobject-addons
Diff against target: 447 lines (+54/-35)
25 files modified
account/board_account_view.xml (+2/-1)
account_accountant/account_accountant_data.xml (+1/-1)
account_voucher/account_voucher_view.xml (+1/-1)
crm/board_crm_view.xml (+2/-1)
crm/crm_data.xml (+1/-1)
event/board_association_view.xml (+2/-1)
event/event_data.xml (+1/-1)
fleet/fleet_board_view.xml (+2/-1)
fleet/fleet_data.xml (+1/-1)
hr/board_hr_view.xml (+2/-1)
hr/res_config_view.xml (+1/-1)
marketing_campaign/marketing_campaign_view.xml (+1/-1)
mrp/board_manufacturing_view.xml (+2/-1)
mrp/res_config_view.xml (+1/-1)
point_of_sale/point_of_sale_data.xml (+1/-1)
point_of_sale/static/src/js/models.js (+20/-3)
point_of_sale/static/src/js/widgets.js (+1/-9)
project/board_project_view.xml (+2/-1)
project/res_config_view.xml (+1/-1)
purchase/board_purchase_view.xml (+2/-1)
purchase/res_config_view.xml (+1/-1)
sale/board_sale_view.xml (+2/-1)
sale/sale_data.xml (+1/-1)
stock/board_warehouse_view.xml (+2/-1)
stock/res_config_view.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-home-action-rga
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+191148@code.launchpad.net
To post a comment you must log in.
8860. By RGA(OpenERP)

Merge with trunk

Unmerged revisions

8860. By RGA(OpenERP)

Merge with trunk

8859. By RGA(OpenERP)

[IMP] Dispaly dialog only for explicitly generated error using .rejectother error can gracefully handel by framework rpc

8858. By RGA(OpenERP)

[IMP] POS: if user have no active session available display error and redirect to your session form view

8857. By RGA(OpenERP)

Merge with trunk

8856. By RGA(OpenERP)

Merge with trunk

8855. By RGA(OpenERP)

Merge with trunk

8854. By RGA(OpenERP)

[IMP] usability: imporve dashboard action name it's more convenient when want to choose as home action

8853. By RGA(OpenERP)

[IMP] usability: imporve client action name it's more convenient when want to choose as home action

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/board_account_view.xml'
2--- account/board_account_view.xml 2012-11-29 22:26:45 +0000
3+++ account/board_account_view.xml 2013-11-11 12:15:46 +0000
4@@ -27,7 +27,7 @@
5 </record>
6
7 <record id="open_board_account" model="ir.actions.act_window">
8- <field name="name">Accounting</field>
9+ <field name="name">Accounting Dashboard</field>
10 <field name="res_model">board.board</field>
11 <field name="view_type">form</field>
12 <field name="view_mode">form</field>
13@@ -36,6 +36,7 @@
14 </record>
15
16 <menuitem id="menu_board_account"
17+ name="Accounting"
18 action="open_board_account"
19 icon="terp-graph"
20 parent="base.menu_reporting_dashboard"
21
22=== modified file 'account_accountant/account_accountant_data.xml'
23--- account_accountant/account_accountant_data.xml 2012-11-29 22:26:45 +0000
24+++ account_accountant/account_accountant_data.xml 2013-11-11 12:15:46 +0000
25@@ -12,7 +12,7 @@
26 <data noupdate="1">
27 <!-- After installation of the module, open the related menu -->
28 <record id="action_client_account_menu" model="ir.actions.client">
29- <field name="name">Open Accounting Menu</field>
30+ <field name="name">Accounting</field>
31 <field name="tag">reload</field>
32 <field name="params" eval="{'menu_id': ref('account.menu_finance')}"/>
33 </record>
34
35=== modified file 'account_voucher/account_voucher_view.xml'
36--- account_voucher/account_voucher_view.xml 2013-10-04 10:52:18 +0000
37+++ account_voucher/account_voucher_view.xml 2013-11-11 12:15:46 +0000
38@@ -271,7 +271,7 @@
39
40 <!-- After installation of the module, open the related menu -->
41 <record id="action_client_invoice_menu" model="ir.actions.client">
42- <field name="name">Open Invoicing Menu</field>
43+ <field name="name">Invoicing</field>
44 <field name="tag">reload</field>
45 <field name="params" eval="{'menu_id': ref('account.menu_finance')}"/>
46 </record>
47
48=== modified file 'crm/board_crm_view.xml'
49--- crm/board_crm_view.xml 2013-07-16 15:15:13 +0000
50+++ crm/board_crm_view.xml 2013-11-11 12:15:46 +0000
51@@ -70,7 +70,7 @@
52 </record>
53
54 <record model="ir.actions.act_window" id="open_board_statistical_dash">
55- <field name="name">CRM</field>
56+ <field name="name">CRM Dashboard</field>
57 <field name="res_model">board.board</field>
58 <field name="view_type">form</field>
59 <field name="view_mode">form</field>
60@@ -80,6 +80,7 @@
61
62 <menuitem
63 id="menu_board_statistics_dash"
64+ name="CRM"
65 parent="base.menu_reporting_dashboard"
66 action="open_board_statistical_dash"
67 sequence="10"
68
69=== modified file 'crm/crm_data.xml'
70--- crm/crm_data.xml 2013-05-21 14:27:53 +0000
71+++ crm/crm_data.xml 2013-11-11 12:15:46 +0000
72@@ -4,7 +4,7 @@
73
74 <!-- After installation of the module, open the related menu -->
75 <record id="action_client_crm_menu" model="ir.actions.client">
76- <field name="name">Open Sale Menu</field>
77+ <field name="name">Sales</field>
78 <field name="tag">reload</field>
79 <field name="params" eval="{'menu_id': ref('base.menu_base_partner')}"/>
80 </record>
81
82=== modified file 'event/board_association_view.xml'
83--- event/board_association_view.xml 2012-11-29 22:26:45 +0000
84+++ event/board_association_view.xml 2013-11-11 12:15:46 +0000
85@@ -60,7 +60,7 @@
86 </record>
87
88 <record model="ir.actions.act_window" id="open_board_associations_manager">
89- <field name="name">Events</field>
90+ <field name="name">Events Dashboard</field>
91 <field name="res_model">board.board</field>
92 <field name="view_type">form</field>
93 <field name="view_mode">form</field>
94@@ -68,6 +68,7 @@
95 </record>
96
97 <menuitem id="menu_board_associations_manager"
98+ name="Events"
99 parent="base.menu_reporting_dashboard"
100 action="open_board_associations_manager"
101 sequence="40"
102
103=== modified file 'event/event_data.xml'
104--- event/event_data.xml 2012-12-05 05:37:32 +0000
105+++ event/event_data.xml 2013-11-11 12:15:46 +0000
106@@ -3,7 +3,7 @@
107 <data noupdate="1">
108 <!-- After installation of the module, open the related menu -->
109 <record id="action_client_event_menu" model="ir.actions.client">
110- <field name="name">Open Event Menu</field>
111+ <field name="name">Event</field>
112 <field name="tag">reload</field>
113 <field name="params" eval="{'menu_id': ref('event.event_main_menu')}"/>
114 </record>
115
116=== modified file 'fleet/fleet_board_view.xml'
117--- fleet/fleet_board_view.xml 2012-12-04 16:20:56 +0000
118+++ fleet/fleet_board_view.xml 2013-11-11 12:15:46 +0000
119@@ -110,7 +110,7 @@
120 </record>
121
122 <record id="open_board_fleet" model="ir.actions.act_window">
123- <field name="name">Fleet</field>
124+ <field name="name">Fleet Dashboard</field>
125 <field name="res_model">board.board</field>
126 <field name="view_type">form</field>
127 <field name="view_mode">form</field>
128@@ -133,6 +133,7 @@
129 </record>
130
131 <menuitem id="menu_fleet_dashboard"
132+ name="Fleet"
133 parent="base.menu_reporting_dashboard"
134 action="open_board_fleet"
135 sequence="50"
136
137=== modified file 'fleet/fleet_data.xml'
138--- fleet/fleet_data.xml 2012-12-10 16:28:34 +0000
139+++ fleet/fleet_data.xml 2013-11-11 12:15:46 +0000
140@@ -18,7 +18,7 @@
141
142 <!-- After installation of the module, open the related menu -->
143 <record id="action_fleet_menu" model="ir.actions.client">
144- <field name="name">Open Fleet Menu</field>
145+ <field name="name">Fleet</field>
146 <field name="tag">reload</field>
147 <field name="params" eval="{'menu_id': ref('fleet.menu_root')}"/>
148 </record>
149
150=== modified file 'hr/board_hr_view.xml'
151--- hr/board_hr_view.xml 2012-11-29 22:26:45 +0000
152+++ hr/board_hr_view.xml 2013-11-11 12:15:46 +0000
153@@ -16,7 +16,7 @@
154 </record>
155
156 <record id="open_board_hr" model="ir.actions.act_window">
157- <field name="name">Human Resources</field>
158+ <field name="name">Human Resources Dashboard</field>
159 <field name="res_model">board.board</field>
160 <field name="view_type">form</field>
161 <field name="view_mode">form</field>
162@@ -38,6 +38,7 @@
163 </field>
164 </record>
165 <menuitem id="menu_hr_dashboard"
166+ name="Human Resources"
167 parent="base.menu_reporting_dashboard"
168 action="open_board_hr"
169 sequence="50"/>
170
171=== modified file 'hr/res_config_view.xml'
172--- hr/res_config_view.xml 2012-11-29 22:26:45 +0000
173+++ hr/res_config_view.xml 2013-11-11 12:15:46 +0000
174@@ -3,7 +3,7 @@
175 <data noupdate="1">
176 <!-- After installation of the module, open the related menu -->
177 <record id="action_client_hr_menu" model="ir.actions.client">
178- <field name="name">Open HR Menu</field>
179+ <field name="name">Human Resources</field>
180 <field name="tag">reload</field>
181 <field name="params" eval="{'menu_id': ref('menu_hr_root')}"/>
182 </record>
183
184=== modified file 'marketing_campaign/marketing_campaign_view.xml'
185--- marketing_campaign/marketing_campaign_view.xml 2013-09-04 14:10:53 +0000
186+++ marketing_campaign/marketing_campaign_view.xml 2013-11-11 12:15:46 +0000
187@@ -3,7 +3,7 @@
188 <data noupdate="1">
189
190 <record id="action_client_marketing_menu" model="ir.actions.client">
191- <field name="name">Open Marketing Menu</field>
192+ <field name="name">Marketing</field>
193 <field name="tag">reload</field>
194 <field name="params" eval="{'menu_id': ref('base.marketing_menu')}"/>
195 </record>
196
197=== modified file 'mrp/board_manufacturing_view.xml'
198--- mrp/board_manufacturing_view.xml 2012-11-29 22:26:45 +0000
199+++ mrp/board_manufacturing_view.xml 2013-11-11 12:15:46 +0000
200@@ -19,7 +19,7 @@
201 </record>
202
203 <record id="open_board_manufacturing" model="ir.actions.act_window">
204- <field name="name">Manufacturing</field>
205+ <field name="name">Manufacturing Dashboard</field>
206 <field name="res_model">board.board</field>
207 <field name="view_type">form</field>
208 <field name="view_mode">form</field>
209@@ -27,6 +27,7 @@
210 </record>
211
212 <menuitem action="open_board_manufacturing"
213+ name="Manufacturing"
214 icon="terp-graph"
215 id="menu_board_manufacturing"
216 parent="base.menu_reporting_dashboard"
217
218=== modified file 'mrp/res_config_view.xml'
219--- mrp/res_config_view.xml 2012-11-29 22:26:45 +0000
220+++ mrp/res_config_view.xml 2013-11-11 12:15:46 +0000
221@@ -3,7 +3,7 @@
222 <data noupdate="1">
223 <!-- After installation of the module, open the related menu -->
224 <record id="action_client_mrp_menu" model="ir.actions.client">
225- <field name="name">Open MRP Menu</field>
226+ <field name="name">MRP</field>
227 <field name="tag">reload</field>
228 <field name="params" eval="{'menu_id': ref('base.menu_mrp_root')}"/>
229 </record>
230
231=== modified file 'point_of_sale/point_of_sale_data.xml'
232--- point_of_sale/point_of_sale_data.xml 2013-04-09 10:09:17 +0000
233+++ point_of_sale/point_of_sale_data.xml 2013-11-11 12:15:46 +0000
234@@ -5,7 +5,7 @@
235
236 <!-- After installation of the module, open the related menu -->
237 <record id="action_client_pos_menu" model="ir.actions.client">
238- <field name="name">Open POS Menu</field>
239+ <field name="name">Point Of Sale</field>
240 <field name="tag">reload</field>
241 <field name="params" eval="{'menu_id': ref('menu_point_root')}"/>
242 </record>
243
244=== modified file 'point_of_sale/static/src/js/models.js'
245--- point_of_sale/static/src/js/models.js 2013-09-23 17:13:10 +0000
246+++ point_of_sale/static/src/js/models.js 2013-11-11 12:15:46 +0000
247@@ -1,5 +1,6 @@
248 function openerp_pos_models(instance, module){ //module is instance.point_of_sale
249 var QWeb = instance.web.qweb;
250+ var _t = instance.web._t;
251
252 var round_di = instance.web.round_decimals;
253 var round_pr = instance.web.round_precision
254@@ -68,10 +69,23 @@
255 .done(function(){
256 //self.log_loaded_data(); //Uncomment if you want to log the data to the console for easier debugging
257 self.ready.resolve();
258- }).fail(function(){
259+ }).fail(function(error){
260 //we failed to load some backend data, or the backend was badly configured.
261- //the error messages will be displayed in PosWidget
262- self.ready.reject();
263+ //the error messages will be displayed in openerp dialog box.
264+ //display error dialog only for explicitly reject deferred using .reject('error')
265+ //if any internal server error occured than server will send error object and handle by framework rpc handler.
266+ instance.web.unblockUI();
267+ if(_.isString(error)){
268+ var dialog = new instance.web.Dialog(this, {
269+ title: _t("Error"),
270+ width: 850,
271+ buttons: [
272+ {text: "OK", click: function() { self.ready.reject();}},
273+ ]
274+ }).open();
275+ $("<div />").text(error).appendTo(dialog.$el);
276+ dialog.on("closing", this, function(){self.ready.reject();});
277+ }
278 });
279 },
280
281@@ -145,6 +159,9 @@
282 [['state', '=', 'opened'], ['user_id', '=', self.session.uid]]
283 );
284 }).then(function(sessions){
285+ if(_.isEmpty(sessions)){
286+ return (new $.Deferred()).reject(_t("There is no active session available for this user."));
287+ }
288 self.set('pos_session', sessions[0]);
289
290 return self.fetch(
291
292=== modified file 'point_of_sale/static/src/js/widgets.js'
293--- point_of_sale/static/src/js/widgets.js 2013-10-09 13:29:44 +0000
294+++ point_of_sale/static/src/js/widgets.js 2013-11-11 12:15:46 +0000
295@@ -889,15 +889,7 @@
296 self.pos.flush();
297
298 }).fail(function(){ // error when loading models data from the backend
299- instance.web.unblockUI();
300- return new instance.web.Model("ir.model.data").get_func("search_read")([['name', '=', 'action_pos_session_opening']], ['res_id'])
301- .pipe( _.bind(function(res){
302- return instance.session.rpc('/web/action/load', {'action_id': res[0]['res_id']})
303- .pipe(_.bind(function(result){
304- var action = result.result;
305- this.do_action(action);
306- }, this));
307- }, self));
308+ self.close();
309 });
310 },
311
312
313=== modified file 'project/board_project_view.xml'
314--- project/board_project_view.xml 2013-07-19 10:01:19 +0000
315+++ project/board_project_view.xml 2013-11-11 12:15:46 +0000
316@@ -47,7 +47,7 @@
317 </record>
318
319 <record id="open_board_project" model="ir.actions.act_window">
320- <field name="name">Project</field>
321+ <field name="name">Project Dashboard</field>
322 <field name="res_model">board.board</field>
323 <field name="view_type">form</field>
324 <field name="view_mode">form</field>
325@@ -56,6 +56,7 @@
326 </record>
327
328 <menuitem id="menu_project_dashboard"
329+ name="Project"
330 sequence="35"
331 parent="base.menu_reporting_dashboard"
332 action="open_board_project"/>
333
334=== modified file 'project/res_config_view.xml'
335--- project/res_config_view.xml 2012-11-29 22:26:45 +0000
336+++ project/res_config_view.xml 2013-11-11 12:15:46 +0000
337@@ -3,7 +3,7 @@
338 <data noupdate="1">
339 <!-- After installation of the module, open the related menu -->
340 <record id="action_client_project_menu" model="ir.actions.client">
341- <field name="name">Open Project Menu</field>
342+ <field name="name">Project</field>
343 <field name="tag">reload</field>
344 <field name="params" eval="{'menu_id': ref('base.menu_main_pm')}"/>
345 </record>
346
347=== modified file 'purchase/board_purchase_view.xml'
348--- purchase/board_purchase_view.xml 2012-11-29 22:26:45 +0000
349+++ purchase/board_purchase_view.xml 2013-11-11 12:15:46 +0000
350@@ -73,7 +73,7 @@
351 </record>
352
353 <record id="open_board_purchase" model="ir.actions.act_window">
354- <field name="name">Purchases</field>
355+ <field name="name">Purchases Dashboard</field>
356 <field name="res_model">board.board</field>
357 <field name="view_type">form</field>
358 <field name="view_mode">form</field>
359@@ -82,6 +82,7 @@
360 </record>
361
362 <menuitem action="open_board_purchase"
363+ name="Purchases"
364 icon="terp-graph"
365 id="menu_board_purchase"
366 parent="base.menu_reporting_dashboard"
367
368=== modified file 'purchase/res_config_view.xml'
369--- purchase/res_config_view.xml 2013-04-18 10:23:37 +0000
370+++ purchase/res_config_view.xml 2013-11-11 12:15:46 +0000
371@@ -3,7 +3,7 @@
372 <data noupdate="1">
373 <!-- After installation of the module, open the related menu -->
374 <record id="action_client_purchase_menu" model="ir.actions.client">
375- <field name="name">Open Purchase Menu</field>
376+ <field name="name">Purchases</field>
377 <field name="tag">reload</field>
378 <field name="params" eval="{'menu_id': ref('base.menu_purchase_root')}"/>
379 </record>
380
381=== modified file 'sale/board_sale_view.xml'
382--- sale/board_sale_view.xml 2012-11-29 22:26:45 +0000
383+++ sale/board_sale_view.xml 2013-11-11 12:15:46 +0000
384@@ -62,7 +62,7 @@
385 </record>
386
387 <record id="open_board_sales" model="ir.actions.act_window">
388- <field name="name">Sales</field>
389+ <field name="name">Sales Dashboard</field>
390 <field name="res_model">board.board</field>
391 <field name="view_type">form</field>
392 <field name="view_mode">form</field>
393@@ -71,6 +71,7 @@
394
395 <menuitem id="menu_dashboard_sales"
396 sequence="15"
397+ name="Sales"
398 parent="base.menu_reporting_dashboard"
399 action="open_board_sales"
400 groups="base.group_sale_salesman"/>
401
402=== modified file 'sale/sale_data.xml'
403--- sale/sale_data.xml 2013-03-18 07:15:19 +0000
404+++ sale/sale_data.xml 2013-11-11 12:15:46 +0000
405@@ -4,7 +4,7 @@
406
407 <!-- After installation of the module, open the related menu -->
408 <record id="action_client_sale_menu" model="ir.actions.client">
409- <field name="name">Open Sale Menu</field>
410+ <field name="name">Sales</field>
411 <field name="tag">reload</field>
412 <field name="params" eval="{'menu_id': ref('base.menu_base_partner')}"/>
413 </record>
414
415=== modified file 'stock/board_warehouse_view.xml'
416--- stock/board_warehouse_view.xml 2012-12-05 12:13:11 +0000
417+++ stock/board_warehouse_view.xml 2013-11-11 12:15:46 +0000
418@@ -50,7 +50,7 @@
419 </record>
420
421 <record id="open_board_warehouse" model="ir.actions.act_window">
422- <field name="name">Warehouse</field>
423+ <field name="name">Warehouse Dashboard</field>
424 <field name="res_model">board.board</field>
425 <field name="view_type">form</field>
426 <field name="view_mode">form</field>
427@@ -58,6 +58,7 @@
428 </record>
429
430 <menuitem id="menu_board_warehouse"
431+ name="Warehouse"
432 parent="base.menu_reporting_dashboard"
433 action="open_board_warehouse"
434 sequence="25"
435
436=== modified file 'stock/res_config_view.xml'
437--- stock/res_config_view.xml 2013-02-20 08:27:07 +0000
438+++ stock/res_config_view.xml 2013-11-11 12:15:46 +0000
439@@ -4,7 +4,7 @@
440
441 <!-- After installation of the module, open the related menu -->
442 <record id="action_client_warehouse_menu" model="ir.actions.client">
443- <field name="name">Open Warehouse Menu</field>
444+ <field name="name">Warehouse</field>
445 <field name="tag">reload</field>
446 <field name="params" eval="{'menu_id': ref('menu_stock_root')}"/>
447 </record>

Subscribers

People subscribed via source and target branches

to all changes: