Merge lp:~openerp-dev/openobject-addons/trunk-edit-subtype-fix-kch into lp:openobject-addons

Proposed by Kunal Chavda
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-edit-subtype-fix-kch
Merge into: lp:openobject-addons
Diff against target: 27 lines (+3/-3)
2 files modified
mail/static/src/js/mail_followers.js (+1/-1)
mail/static/src/xml/mail_followers.xml (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-edit-subtype-fix-kch
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+176657@code.launchpad.net

Description of the change

Fixed issue like, while we clicked on subtype label from edit subtype dialog box it should be checked same subtype.
But currently it checked subtype of parent window.
I have passed dialog value to xml and on the basis of dialog value it add some value in t-att-id of record. so it will be identified by that id to check wheather it is from dialog box or parent window.

Thanks,
Kunal Chavda.

To post a comment you must log in.
8831. By Kunal Chavda

[REM]remove unwanted diff line.

8832. By Vidhin Mehta (OpenERP)

[fix]

Unmerged revisions

8832. By Vidhin Mehta (OpenERP)

[fix]

8831. By Kunal Chavda

[REM]remove unwanted diff line.

8830. By Kunal Chavda

[FIX]Fixed while click on label from subtype dialogbox it should checked in dialogbox subtype.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mail/static/src/js/mail_followers.js'
2--- mail/static/src/js/mail_followers.js 2013-07-23 09:55:09 +0000
3+++ mail/static/src/js/mail_followers.js 2013-07-24 11:47:26 +0000
4@@ -270,7 +270,7 @@
5 _(records).each(function (record, record_name) {
6 record.name = record_name;
7 record.followed = record.followed || undefined;
8- $(session.web.qweb.render('mail.followers.subtype', {'record': record})).appendTo($list);
9+ $(session.web.qweb.render('mail.followers.subtype', {'record': record,'dialog': dialog})).appendTo($list);
10 });
11 if (_.size(records) > 1) {
12 $list.show();
13
14=== modified file 'mail/static/src/xml/mail_followers.xml'
15--- mail/static/src/xml/mail_followers.xml 2013-07-23 09:55:09 +0000
16+++ mail/static/src/xml/mail_followers.xml 2013-07-24 11:47:26 +0000
17@@ -42,8 +42,8 @@
18 <t t-name="mail.followers.subtype">
19 <table class='oe_subtype'>
20 <tr>
21- <td width="10%"><input type="checkbox" t-att-checked="record.followed" t-att-id="'input_mail_followers_subtype_'+record.id" t-att-data-id="record.id" t-att-name="record.name" class="oe_msg_subtype_check"/></td>
22- <td><label t-att-for="'input_mail_followers_subtype_'+record.id"><t t-raw="record.name"/></label></td>
23+ <td width="10%"><input type="checkbox" t-att-checked="record.followed" t-att-id="'input_mail_followers_subtype_'+record.id+(dialog ? '_in_dialog': '')" t-att-data-id="record.id" t-att-name="record.name" class="oe_msg_subtype_check"/></td>
24+ <td><label t-att-for="'input_mail_followers_subtype_'+record.id+(dialog ? '_in_dialog': '')"><t t-raw="record.name"/></label></td>
25 </tr>
26 </table>
27 </t>

Subscribers

People subscribed via source and target branches

to all changes: