Merge lp:~openerp-dev/openobject-addons/trunk-bug-953324-mma into lp:openobject-addons

[Mayur Maheshwari(OpenERP)]

Hello,

       stock: I Have added check_uom constraints in stock.move and stock.inventory.line Object

Thanks.
mma

[Purnendu Singh (OpenERP) (purnendu-singh)]

it can be fix by implementing on_change on UMO directly!!!

Thanks,
Purnendu Singh

review: Needs Fixing

[Amit Parik (amit-parik)]

Hello Purnendu,

I think Mayur is correct, cause If some one try to import the inventory form csv file and he used the wrong uom for then product then on_change will not raise.

So As per my Opinion check_uom constraint is better way to do this.

Thank you!

Unmerged revisions

6670. By Juan Márquez on 2012-03-13

[FIX]stock: added check_uom constraints in stock.move and stock.inventory.line Object

=== modified file 'stock/stock.py'
--- stock/stock.py	2012-02-28 14:08:16 +0000
+++ stock/stock.py	2012-03-13 11:35:23 +0000
@@ -1610,6 +1610,13 @@
             if (record.state=='done') and (record.location_dest_id.usage == 'view' or record.location_id.usage == 'view'):
                 return False
         return True
+    
+    def _check_uom(self, cr, uid, ids, context=None):
+        for move in self.browse(cr, uid, ids, context=context):
+            product = self.pool.get('product.product').browse(cr, uid, move.product_id.id, context=context)
+            if product.uom_id.category_id.id != move.product_uom.category_id.id:
+                return False
+        return True
 
     _constraints = [
         (_check_tracking,
@@ -1617,6 +1624,8 @@
             ['prodlot_id']),
         (_check_location, 'You can not move products from or to a location of the type view.',
             ['location_id','location_dest_id']),
+        (_check_uom, 'UoM categories Mismatch: The move UOM and the product UOM must be in the same category.', 
+            ['product_uom']),
         (_check_product_lot,
             'You try to assign a lot which is not from the same product',
             ['prodlot_id'])]
@@ -2749,6 +2758,17 @@
         'state': fields.related('inventory_id','state',type='char',string='State',readonly=True),
     }
 
+    def _check_uom(self, cr, uid, ids, context=None):
+        for line in self.browse(cr, uid, ids, context=context):
+            product = self.pool.get('product.product').browse(cr, uid, line.product_id.id, context=context)
+            if product.uom_id.category_id.id != line.product_uom.category_id.id:
+                return False
+        return True
+
+    _constraints = [
+        (_check_uom, 'UoM categories Mismatch: The line UOM and the product UOM must be in the same category.', ['product_uom']),
+    ]
+
     def on_change_product_id(self, cr, uid, ids, location_id, product, uom=False, to_date=False):
         """ Changes UoM and name if product_id changes.
         @param location_id: Location id