Merge lp:~openerp-dev/openobject-addons/trunk-bug-916563-mdi into lp:openobject-addons

Proposed by DJ Patel (OpenERP)
Status: Rejected
Rejected by: Thibault Delavallée (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-916563-mdi
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
account/account_view.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-916563-mdi
Reviewer Review Type Date Requested Status
Thibault Delavallée (OpenERP) (community) Disapprove
Meera Trambadia (OpenERP) (community) Needs Fixing
Review via email: mp+88650@code.launchpad.net

Description of the change

Hello Sir,

I have fix the issue: https://bugs.launchpad.net/openobject-addons/+bug/916563 "Can't edit Journal entries".

I remove one2many field from context.

Thanks and Regards,

Divyesh Makwana(MDI)

To post a comment you must log in.
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello Divyesh,

I think you shouldn't remove o2m field from the context.
Verify the significance of passing the o2m field in context and what if you dont pass that..or is it a problem with web-client!

Please check.

Thanks,
Meera

review: Needs Fixing
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

This has been fixed in a previous revision. Please refer to the bug for more details.

Regards,

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_view.xml'
2--- account/account_view.xml 2012-01-06 11:09:14 +0000
3+++ account/account_view.xml 2012-01-16 09:41:31 +0000
4@@ -1363,7 +1363,7 @@
5 </group>
6 <notebook colspan="4">
7 <page string="Journal Items">
8- <field colspan="4" name="line_id" nolabel="1" height="250" widget="one2many_list" context="{'lines':line_id ,'journal':journal_id }">
9+ <field colspan="4" name="line_id" nolabel="1" height="250" widget="one2many_list" context="{'journal':journal_id }">
10 <form string="Journal Item">
11 <group col="6" colspan="4">
12 <field name="name"/>

Subscribers

People subscribed via source and target branches

to all changes: