Merge lp:~openerp-dev/openobject-addons/trunk-bug-916526-mdi into lp:openobject-addons

Proposed by DJ Patel (OpenERP)
Status: Merged
Merged at revision: 6445
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-916526-mdi
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
hr_payroll/hr_payroll.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-916526-mdi
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Approve
Purnendu Singh (OpenERP) (community) Needs Resubmitting
qdp (OpenERP) Pending
Review via email: mp+89022@code.launchpad.net

Description of the change

Hello Sir,

I have fix the issue: https://bugs.launchpad.net/openobject-addons/+bug/916526 "
hr payroll please correct text".

Thanks and Regards,

Divyesh Makwana(MDI)

To post a comment you must log in.
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) :
review: Approve
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Can you please rewrite this sentence in proper English? It's incomprehensible to me.
I propose : "This will be used to compute the % fields values; in general it is on basic, but you can also use categories code fields in lowercase as a variable names (hra, ma, lta, etc.) and the variable basic." (This is based on my understanding of the sentence.)

Thanks,
Raphael

review: Needs Fixing
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello Raphael Collet,

Improve the help string as per your suggestion.

Thanks,
Purnendu Singh

review: Needs Fixing
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) :
review: Needs Resubmitting
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Thanks,
Raphael

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_payroll/hr_payroll.py'
2--- hr_payroll/hr_payroll.py 2012-01-05 08:13:25 +0000
3+++ hr_payroll/hr_payroll.py 2012-01-27 05:46:19 +0000
4@@ -772,7 +772,7 @@
5 'parent_rule_id':fields.many2one('hr.salary.rule', 'Parent Salary Rule', select=True),
6 'company_id':fields.many2one('res.company', 'Company', required=False),
7 'condition_select': fields.selection([('none', 'Always True'),('range', 'Range'), ('python', 'Python Expression')], "Condition Based on", required=True),
8- 'condition_range':fields.char('Range Based on',size=1024, readonly=False, help='This will use to computer the % fields values, in general its on basic, but You can use all categories code field in small letter as a variable name i.e. hra, ma, lta, etc...., also you can use, static varible basic'),
9+ 'condition_range':fields.char('Range Based on',size=1024, readonly=False, help='This will be used to compute the % fields values; in general it is on basic, but you can also use categories code fields in lowercase as a variable names (hra, ma, lta, etc.) and the variable basic.'),
10 'condition_python':fields.text('Python Condition', required=True, readonly=False, help='Applied this rule for calculation if condition is true. You can specify condition like basic > 1000.'),#old name = conditions
11 'condition_range_min': fields.float('Minimum Range', required=False, help="The minimum amount, applied for this rule."),
12 'condition_range_max': fields.float('Maximum Range', required=False, help="The maximum amount, applied for this rule."),

Subscribers

People subscribed via source and target branches

to all changes: