Merge lp:~openerp-dev/openobject-addons/trunk-bug-914692-kjo into lp:openobject-addons

Proposed by Kuldeep Joshi(OpenERP)
Status: Merged
Merged at revision: 6524
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-914692-kjo
Merge into: lp:openobject-addons
Diff against target: 0 lines
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-914692-kjo
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Needs Resubmitting
Numérigraphe (community) Abstain
Review via email: mp+91209@code.launchpad.net

Description of the change

following addons are migrated from wizard.interface to osv.osv_memory

* base_module_doc_rst
* base_module_record
* base_report_creator

Remove <wizard/> tags left in these files which don't have wizard.interface objects

* account_asset/account_asset_wizard.xml
* crm/wizard/crm_phonecall_to_meeting_view.xml
* hr_timesheet/hr_timesheet_report.xm

To post a comment you must log in.
Revision history for this message
Numérigraphe (numerigraphe) wrote :

base_module_doc_rst/wizard/tech_guide_rst.py looks a lot like the old base_module_doc_rst/wizard/wizard_tech_guide_rst.py, I suppose it should have been renamed instead of deleted+created.
Lionel Sausin.

review: Needs Fixing (bzr history consistency)
Revision history for this message
Kuldeep Joshi(OpenERP) (kjo-openerp) wrote :

Rename the file as per your suggestion

Thank You

Revision history for this message
Numérigraphe (numerigraphe) :
review: Approve
Revision history for this message
Numérigraphe (numerigraphe) :
review: Abstain
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

In base_module_doc_rst/wizard/generate_relation_graph.py (line 119 of diff), couldn't you use context['active_ids'] instead of context['ids']? This would simplify the corresponding action defined in base_module_doc_rst/wizard/generate_relation_graph_view.xml, as no explicit context would be required.

In base_module_doc_rst/wizard/tech_guide_rst.py (line 658 of diff), the dictionary _defaults is wrongly indented! The file would always be empty, then. Have you tested it?

review: Needs Fixing
Revision history for this message
Kuldeep Joshi(OpenERP) (kjo-openerp) wrote :

Change is done as per your suggestion

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

In module base_module_doc_rst, the wizard "Create RST Technical Guide2" does not work.
The report "Proximity graph" generates an error in the web client.

review: Needs Fixing
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

In module base_module_record: the wizard "Export Customization as Data" triggers an error:

Integrity Error

The operation cannot be completed, probably due to the following:
- deletion: you may be trying to delete a record while other records still reference it
- creation/update: a mandatory field is not correctly set

[object with reference: Base Module Record - base.module.record]

Please fix and test it!

review: Needs Fixing
Revision history for this message
Kuldeep Joshi(OpenERP) (kjo-openerp) wrote :

I fix the problem of base_module_record and Proximity graph. For the "Create RST Technical Guide2" wizard is work fine in gtk but in web the context is not pass properly accordingly my knowledge so it give error correct me if i am wrong

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

simplified a bit the code of base_module_record

review: Needs Resubmitting
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Now it looks fine to me.

review: Needs Resubmitting

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: