Merge lp:~openerp-dev/openobject-addons/trunk-bug-908189-jap into lp:openobject-addons

Proposed by Jagdish Panchal (Open ERP)
Status: Rejected
Rejected by: Thibault Delavallée (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-908189-jap
Merge into: lp:openobject-addons
Diff against target: 67 lines (+0/-7)
3 files modified
purchase/purchase_sequence.xml (+0/-1)
sale/sale_sequence.xml (+0/-1)
stock/stock_sequence.xml (+0/-5)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-908189-jap
Reviewer Review Type Date Requested Status
Thibault Delavallée (OpenERP) (community) Disapprove
Review via email: mp+87129@code.launchpad.net

Description of the change

Hello,

 Sale, Stock, Purchase: Sequence set with company_id: --fixes=lp:908189

Thanks
JAP

To post a comment you must log in.
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

The line <field name="company_id" eval="False"/> in files purchase_sequence.xml, sale_sequence.xml and stock_sequence.xml has been added to make sequences shared by default in multicompany. This has been done in revision 5217 to which you can refer for more details.

We therefore consider this branch as refused and the related bug as invalid because this default behavior of sequences is intended.

Best regards,

Thibault.

review: Disapprove

Unmerged revisions

6203. By Jagdish Panchal (Open ERP)

[FIX] sale,stoke,purchase: sequence is set with company_id

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'purchase/purchase_sequence.xml'
2--- purchase/purchase_sequence.xml 2011-10-16 01:28:00 +0000
3+++ purchase/purchase_sequence.xml 2011-12-30 10:39:24 +0000
4@@ -11,7 +11,6 @@
5 <field name="code">purchase.order</field>
6 <field name="prefix">PO</field>
7 <field name="padding">5</field>
8- <field name="company_id" eval="False"/>
9 </record>
10 </data>
11 </openerp>
12
13=== modified file 'sale/sale_sequence.xml'
14--- sale/sale_sequence.xml 2011-12-19 16:54:40 +0000
15+++ sale/sale_sequence.xml 2011-12-30 10:39:24 +0000
16@@ -13,7 +13,6 @@
17 <field name="code">sale.order</field>
18 <field name="prefix">SO</field>
19 <field name="padding">3</field>
20- <field name="company_id" eval="False"/>
21 </record>
22
23 </data>
24
25=== modified file 'stock/stock_sequence.xml'
26--- stock/stock_sequence.xml 2011-10-16 01:28:00 +0000
27+++ stock/stock_sequence.xml 2011-12-30 10:39:24 +0000
28@@ -29,7 +29,6 @@
29 <field name="code">stock.picking.in</field>
30 <field name="prefix">IN/</field>
31 <field name="padding">5</field>
32- <field name="company_id" eval="False"/>
33 </record>
34
35 <record id="seq_picking_out" model="ir.sequence">
36@@ -37,7 +36,6 @@
37 <field name="code">stock.picking.out</field>
38 <field name="prefix">OUT/</field>
39 <field name="padding">5</field>
40- <field name="company_id" eval="False"/>
41 </record>
42
43 <record id="seq_picking_internal" model="ir.sequence">
44@@ -45,7 +43,6 @@
45 <field name="code">stock.picking.internal</field>
46 <field name="prefix">INT/</field>
47 <field name="padding">5</field>
48- <field name="company_id" eval="False"/>
49 </record>
50
51 <!--
52@@ -62,7 +59,6 @@
53 <field name="padding">7</field>
54 <field name="number_next">1</field>
55 <field name="number_increment">1</field>
56- <field name="company_id" eval="False"/>
57 </record>
58
59 <record id="sequence_type_tracking" model="ir.sequence.type">
60@@ -77,7 +73,6 @@
61 <field name="padding">7</field>
62 <field name="number_next">1</field>
63 <field name="number_increment">1</field>
64- <field name="company_id" eval="False"/>
65 </record>
66 </data>
67 </openerp>

Subscribers

People subscribed via source and target branches

to all changes: