Merge lp:~openerp-dev/openobject-addons/trunk-bug-904029-ksa into lp:openobject-addons

Proposed by Kirti Savalia(OpenERP)
Status: Work in progress
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-904029-ksa
Merge into: lp:openobject-addons
Diff against target: 11 lines (+1/-1)
1 file modified
purchase/stock.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-904029-ksa
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Approve
Kirti Savalia(OpenERP) (community) Needs Resubmitting
Fabien (Open ERP) Disapprove
Rucha (Open ERP) (community) Approve
qdp (OpenERP) Pending
Review via email: mp+86945@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rucha (Open ERP) (rpa-openerp) wrote :

well it seems a nice improvement,
but if you see on bug report Ferdinand have a problem with the code "move.product_id.standard_price"
which is actually not in latest trunk, so there is no chance of problem,
Can you please check?

thanks

review: Approve
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

not sure it's good.
It has to be clear on which cost we take, and not one of the three.

review: Disapprove
Revision history for this message
Kirti Savalia(OpenERP) (ksa-openerp) :
review: Needs Resubmitting
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) :
review: Approve

Unmerged revisions

6169. By Kirti Savalia(OpenERP)

[MERGE]:with latest addons

6168. By Kirti Savalia(OpenERP)

[IMP]:use the price for move

6167. By Kirti Savalia(OpenERP)

[FIX]:average price value in stock move

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'purchase/stock.py'
2--- purchase/stock.py 2011-12-19 16:54:40 +0000
3+++ purchase/stock.py 2012-01-25 11:46:26 +0000
4@@ -127,7 +127,7 @@
5 # incoming pickings.
6 def _product_cost_for_average_update(self, cr, uid, move):
7 if move.picking_id.purchase_id:
8- return {'cost': move.purchase_line_id.price_unit,
9+ return {'cost': move.price_unit,
10 'currency': move.picking_id.purchase_id.pricelist_id.currency_id.id}
11 return super(stock_partial_picking, self)._product_cost_for_average_update(cr, uid, move)
12

Subscribers

People subscribed via source and target branches

to all changes: