Merge lp:~openerp-dev/openobject-addons/trunk-bug-903474-kjo into lp:openobject-addons

Proposed by Kuldeep Joshi(OpenERP)
Status: Merged
Merged at revision: 6270
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-903474-kjo
Merge into: lp:openobject-addons
Diff against target: 41 lines (+9/-3)
2 files modified
portal/portal.py (+8/-2)
portal/portal_view.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-903474-kjo
Reviewer Review Type Date Requested Status
Thibault Delavallée (OpenERP) (community) Approve
Kuldeep Joshi(OpenERP) (community) Needs Resubmitting
Bhumika Shrimali (community) Needs Fixing
Review via email: mp+85837@code.launchpad.net

Description of the change

create record of ir_model_data and ir_value for new portal

To post a comment you must log in.
Revision history for this message
Bhumika Shrimali (sbh-openerp) wrote :

Hello,

When i click Create Menu , server side i get this warning
2011-12-19 05:30:30,266][?] WARNING:orm:No such field(s) in model ir.model.data: groups_id, parent_id.
[2011-12-19 05:30:30,269][?] WARNING:orm:No such field(s) in model ir.values: groups_id, noupdate, module, parent_id.

Thanks

review: Needs Fixing
Revision history for this message
Kuldeep Joshi(OpenERP) (kjo-openerp) wrote :

Hello Madam,

Change is done as per your suggestion

review: Needs Resubmitting
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

Thanks for your fix ! It has been merged into trunk.

Regards,

Thibault.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'portal/portal.py'
2--- portal/portal.py 2011-11-22 08:51:38 +0000
3+++ portal/portal.py 2011-12-20 10:37:54 +0000
4@@ -98,8 +98,8 @@
5 def do_create_menu(self, cr, uid, ids, context=None):
6 """ create a parent menu for the given portals """
7 menu_obj = self.pool.get('ir.ui.menu')
8+ ir_data = self.pool.get('ir.model.data')
9 menu_root = self._res_xml_id(cr, uid, 'portal', 'portal_menu')
10-
11 for p in self.browse(cr, uid, ids, context):
12 # create a menuitem under 'portal.portal_menu'
13 menu_values = {
14@@ -110,7 +110,13 @@
15 menu_id = menu_obj.create(cr, uid, menu_values, context)
16 # set the parent_menu_id to item_id
17 self.write(cr, uid, [p.id], {'parent_menu_id': menu_id}, context)
18-
19+ menu_values.pop('parent_id')
20+ menu_values.pop('groups_id')
21+ menu_values.update({'model': 'ir.ui.menu',
22+ 'module': 'portal',
23+ 'res_id': menu_id,
24+ 'noupdate': 'True'})
25+ data_id = ir_data.create(cr, uid, menu_values, context)
26 return True
27
28 def _assign_menu(self, cr, uid, ids, context=None):
29
30=== modified file 'portal/portal_view.xml'
31--- portal/portal_view.xml 2011-08-02 13:50:30 +0000
32+++ portal/portal_view.xml 2011-12-20 10:37:54 +0000
33@@ -21,7 +21,7 @@
34 </record>
35 <menuitem name="Portals" id="portal_list_menu"
36 parent="portal_menu" sequence="1" action="portal_list_action"/>
37-
38+
39 <!-- portal tree view -->
40 <record id="portal_list_view" model="ir.ui.view">
41 <field name="name">Portal List</field>

Subscribers

People subscribed via source and target branches

to all changes: