Merge lp:~openerp-dev/openobject-addons/trunk-bug-872675-bde into lp:openobject-addons

Proposed by Bharat Devnani (Open ERP)
Status: Merged
Merged at revision: 5428
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-872675-bde
Merge into: lp:openobject-addons
Diff against target: 38 lines (+4/-4)
2 files modified
point_of_sale/wizard/pos_payment_report_date.py (+1/-1)
point_of_sale/wizard/pos_payment_report_date_view.xml (+3/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-872675-bde
Reviewer Review Type Date Requested Status
Purnendu Singh (OpenERP) (community) Approve
qdp (OpenERP) Pending
OpenERP Core Team Pending
Review via email: mp+79920@code.launchpad.net

Description of the change

Hello Sir,

I have changed the table name of field user_id in point_of_sale/wizard/pos_payment_report_user.py.

Thanks & Regards,
Devnani Bharat R.

To post a comment you must log in.
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello,

Please change the label of the wizard as it is confusing Its "Sales by Products" but we select users in the wizard.

and the table name "res_user_sale_user" in your patch is also not good.

Thanks,
Purnendu Singh

review: Needs Fixing
Revision history for this message
Bharat Devnani (Open ERP) (bde-openerp) wrote :

Hello Sir,

I have changed the table name and given appropriate menu name for report.

Thanks & Regards,
Devnani Bharat R.

Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'point_of_sale/wizard/pos_payment_report_date.py'
2--- point_of_sale/wizard/pos_payment_report_date.py 2011-01-14 00:11:01 +0000
3+++ point_of_sale/wizard/pos_payment_report_date.py 2011-10-20 10:09:25 +0000
4@@ -55,7 +55,7 @@
5 _columns = {
6 'date_start': fields.date('Start Date', required=True),
7 'date_end': fields.date('End Date', required=True),
8- 'user_id': fields.many2many('res.users', 'res_user_sale', 'user_id', 'sale_id', 'Salesman')
9+ 'user_id': fields.many2many('res.users', 'res_user_sale_date', 'user_id', 'sale_id', 'Salesman')
10 }
11 _defaults = {
12 'date_start': lambda *a: time.strftime('%Y-%m-%d'),
13
14=== modified file 'point_of_sale/wizard/pos_payment_report_date_view.xml'
15--- point_of_sale/wizard/pos_payment_report_date_view.xml 2011-10-02 17:31:16 +0000
16+++ point_of_sale/wizard/pos_payment_report_date_view.xml 2011-10-20 10:09:25 +0000
17@@ -21,13 +21,13 @@
18 <button name="print_report" string="Print Report"
19 colspan="1" type="object" icon="gtk-print" />
20 </group>
21- </group>
22+ </group>
23 </form>
24 </field>
25 </record>
26
27 <record id="action_report_pos_payment_repport_date" model="ir.actions.act_window">
28- <field name="name">Sales by Products</field>
29+ <field name="name">Sales by Users</field>
30 <field name="type">ir.actions.act_window</field>
31 <field name="res_model">pos.payment.report.date</field>
32 <field name="view_type">form</field>
33@@ -35,4 +35,4 @@
34 <field name="target">new</field>
35 </record>
36 </data>
37-</openerp>
38+</openerp>

Subscribers

People subscribed via source and target branches

to all changes: