Merge lp:~openerp-dev/openobject-addons/trunk-bug-817430-ara into lp:openobject-addons
Proposed by
Ashvin Rathod (OpenERP)
Status: | Rejected |
---|---|
Rejected by: | Olivier Dony (Odoo) |
Proposed branch: | lp:~openerp-dev/openobject-addons/trunk-bug-817430-ara |
Merge into: | lp:openobject-addons |
Diff against target: |
16 lines (+2/-2) 1 file modified
account/account.py (+2/-2) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-817430-ara |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Dony (Odoo) | Disapprove | ||
Mustufa Rangwala (Open ERP) (community) | Approve | ||
qdp (OpenERP) | Pending | ||
Review via email:
|
Description of the change
Hello,
Fix: Multicompany - Product Default Tax (ir.values) only for one company?
Thanks,
ara
To post a comment you must log in.
Hello,
I'm rejecting this merge proposal, not because it's bad, but because the bug should be fully fixed by the framework. The way ir.values.set() was calling by the account module is correct, so there is no reason to fix addons.
If the server is fixed properly, this patch will not be needed at all.
A complete server fix is currently available as a merge proposal, btw: https:/ /code.launchpad .net/~openerp- dev/openobject- server/ trunk-cleanup- ir-values/ +merge/ 73809
Thanks for your help!