Merge lp:~openerp-dev/openobject-addons/trunk-bug-817430-ara into lp:openobject-addons

[Ashvin Rathod (OpenERP)]

Hello,

Fix: Multicompany - Product Default Tax (ir.values) only for one company?

Thanks,
ara

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

review: Approve

[Olivier Dony (Odoo) (odo-openerp)]

Hello,

I'm rejecting this merge proposal, not because it's bad, but because the bug should be fully fixed by the framework. The way ir.values.set() was calling by the account module is correct, so there is no reason to fix addons.
If the server is fixed properly, this patch will not be needed at all.

A complete server fix is currently available as a merge proposal, btw: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-cleanup-ir-values/+merge/73809

Thanks for your help!

review: Disapprove

=== modified file 'account/account.py'
--- account/account.py	2011-07-18 08:34:24 +0000
+++ account/account.py	2011-08-01 10:28:32 +0000
@@ -3060,10 +3060,10 @@
                     obj_ac_fp.create(cr, uid, vals_acc)
 
         if obj_multi.sale_tax:
-            ir_values_obj.set(cr, uid, key='default', key2=False, name="taxes_id", company=obj_multi.company_id.id,
+            ir_values_obj.set(cr, uid, key='default', key2=False, replace=False, name="taxes_id", company=obj_multi.company_id.id,
                             models =[('product.product',False)], value=[tax_template_to_tax[obj_multi.sale_tax.id]])
         if obj_multi.purchase_tax:
-            ir_values_obj.set(cr, uid, key='default', key2=False, name="supplier_taxes_id", company=obj_multi.company_id.id,
+            ir_values_obj.set(cr, uid, key='default', key2=False, replace=False, name="supplier_taxes_id", company=obj_multi.company_id.id,
                             models =[('product.product',False)], value=[tax_template_to_tax[obj_multi.purchase_tax.id]])
 
 wizard_multi_charts_accounts()