Merge lp:~openerp-dev/openobject-addons/trunk-bug-788297-mtr into lp:openobject-addons

Proposed by Meera Trambadia (OpenERP)
Status: Merged
Merged at revision: 5067
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-788297-mtr
Merge into: lp:openobject-addons
Diff against target: 25 lines (+2/-2)
2 files modified
hr_timesheet/report/user_timesheet.py (+1/-1)
hr_timesheet/report/users_timesheet.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-788297-mtr
Reviewer Review Type Date Requested Status
Mustufa Rangwala (Open ERP) (community) Approve
Meera Trambadia (OpenERP) (community) Needs Resubmitting
qdp (OpenERP) Pending
Review via email: mp+64364@code.launchpad.net

Description of the change

hr_timesheet: fixed employee and employees timesheet report, shows correct quantity(without using unit_factor)" --fixes=lp:788297

To post a comment you must log in.
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

your patch is not consistent with different UOM categories.
I replied on the bug for that.

Thanks,
mra

review: Needs Fixing
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello sir,

I have made changes as mentioned above.

Thanks,
mtr

review: Needs Resubmitting
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_timesheet/report/user_timesheet.py'
2--- hr_timesheet/report/user_timesheet.py 2011-02-07 11:38:37 +0000
3+++ hr_timesheet/report/user_timesheet.py 2011-09-16 05:34:24 +0000
4@@ -67,7 +67,7 @@
5 if user_id:
6 # Computing the attendence by analytical account
7 cr.execute(
8- "select line.date, (unit_amount * unit.factor) as amount, account_id, account.name "\
9+ "select line.date, (unit_amount / unit.factor) as amount, account_id, account.name "\
10 "from account_analytic_line as line, hr_analytic_timesheet as hr, "\
11 "account_analytic_account as account, product_uom as unit "\
12 "where hr.line_id=line.id and line.account_id=account.id "\
13
14=== modified file 'hr_timesheet/report/users_timesheet.py'
15--- hr_timesheet/report/users_timesheet.py 2011-01-17 11:35:21 +0000
16+++ hr_timesheet/report/users_timesheet.py 2011-09-16 05:34:24 +0000
17@@ -37,7 +37,7 @@
18 def emp_create_xml(cr, id, som, eom, emp):
19 # Computing the attendence by analytical account
20 cr.execute(
21- "select line.date, (unit_amount * unit.factor) as amount "\
22+ "select line.date, (unit_amount / unit.factor) as amount "\
23 "from account_analytic_line as line, hr_analytic_timesheet as hr, "\
24 "product_uom as unit "\
25 "where hr.line_id=line.id "\

Subscribers

People subscribed via source and target branches

to all changes: