Merge lp:~openerp-dev/openobject-addons/trunk-bug-785147-ara into lp:openobject-addons

Proposed by Ashvin Rathod (OpenERP)
Status: Rejected
Rejected by: qdp (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-785147-ara
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
account/account_view.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-785147-ara
Reviewer Review Type Date Requested Status
qdp (OpenERP) Disapprove
Mustufa Rangwala (Open ERP) (community) Approve
Review via email: mp+70119@code.launchpad.net

Description of the change

Hello,

Fix: Bad code in New Company Financial Setting, or more likely in every localisation module in 6

Thanks,
ara

To post a comment you must log in.
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) :
review: Approve
Revision history for this message
qdp (OpenERP) (qdp) wrote :

you can't do that change, it's just wrong, it means you can not run again the configuration for a company from the menuiten, as the second step will never be shown.

Solution has to be chosen accordingly to last development on the accounting wizard and thus, should be discussed first with Antony.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_view.xml'
2--- account/account_view.xml 2011-07-22 13:42:35 +0000
3+++ account/account_view.xml 2011-08-02 07:31:35 +0000
4@@ -2433,7 +2433,7 @@
5 <field name="model_id" ref="base.model_ir_actions_todo"/>
6 <field eval="5" name="sequence"/>
7 <field name="code">
8-act_window_ids = self.pool.get('ir.actions.act_window').search(cr, uid,[('name', 'in', ('Accounting Chart Configuration', 'Generate Chart of Accounts from a Chart Template'))], context=context)
9+act_window_ids = self.pool.get('ir.actions.act_window').search(cr, uid,[('name', '=', ('Accounting Chart Configuration'))], context=context)
10 todo_ids = self.pool.get('ir.actions.todo').search(cr, uid, [('action_id', 'in', act_window_ids)], context=context)
11 self.pool.get('ir.actions.todo').write(cr, uid, todo_ids, {'state':'open'}, context=context)
12 action = self.pool.get('res.config').next(cr, uid, [], context)

Subscribers

People subscribed via source and target branches

to all changes: