Merge lp:~openerp-dev/openobject-addons/trunk-bug-782168-uco into lp:openobject-addons

[Ujjvala Collins]

[FIX] sale: Corrected compute button functionality for different pricelist using different currencies.

[Graeme Gellatly (gdgellatly)]

Hi,

I am so glad you went this way to fixing it, much more sensible, enforcing one pricelist per order.

However, there is a major bug in your code. What if the user changed the price manually? You will overwrite all his manual changes. I think you would be better implementing this in an onchange pricelist function.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

I agree with Graeme Gellatly comment.

review: Needs Fixing

[Olivier Dony (Odoo) (odo-openerp)]

I agree that this patch is incorrect, but I'm afraid the other suggestions are not correct either.
In fact, after discussing with R&D management, we are more inclined to close the bug as invalid, because it is really an exception case.
As always with OpenERP, we don't want or plan to handle automatically all exception cases, because there is no safe way of doing that. If we enforce one behavior (e.g. automatic recompute), there will be other users who will need the opposite behavior, and will have more trouble *after the fix* than before. See more details in the bug comments.

review: Disapprove

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

As we are making the solution for this bug with tooltips or on change on price list with warning message so for now we are not considering changes from this merge proposal.

Thanks,
mra

review: Disapprove

[Fabien (Open ERP) (fp-tinyerp)]

I made another fix in r5114

=== modified file 'sale/sale.py'
--- sale/sale.py	2011-05-18 16:45:45 +0000
+++ sale/sale.py	2011-06-20 11:36:02 +0000
@@ -370,6 +370,18 @@
         return super(sale_order, self).create(cr, uid, vals, context=context)
 
     def button_dummy(self, cr, uid, ids, context=None):
+        sale_obj = self.browse(cr, uid, ids[0], context=context)
+        sale_line_obj = self.pool.get('sale.order.line')
+        pricelist_obj = self.pool.get('product.pricelist')
+        pricelist = sale_obj.pricelist_id.id
+        for line in sale_obj.order_line:
+            if line.product_id:
+                price = pricelist_obj.price_get(cr, uid, [pricelist],
+                        line.product_id.id, line.product_uom_qty or 1.0, sale_obj.partner_id.id, {
+                            'uom': line.product_uom.id,
+                            'date': sale_obj.date_order,
+                            })[pricelist]
+                sale_line_obj.write(cr, uid, line.id, {'price_unit': price}, context=context)
         return True
 
     #FIXME: the method should return the list of invoices created (invoice_ids)