Merge lp:~openerp-dev/openobject-addons/trunk-bug-757687-ara into lp:openobject-addons

[Ashvin Rathod (OpenERP)]

Hello,

Fix: Wrong account for invoice lines created from delivery for service products

Thanks,
Ashvin Rathod

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

It will give error in context is None.

Fix it please.

thanks,
mra

review: Needs Fixing

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

hello,

I have changed as you describe above.

Thanks,
ara

review: Needs Resubmitting

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

review: Approve

[qdp (OpenERP) (qdp)]

seems weird.. need to double-check

=== modified file 'sale/stock.py'
--- sale/stock.py	2011-02-23 10:22:43 +0000
+++ sale/stock.py	2011-04-14 09:36:04 +0000
@@ -116,9 +116,13 @@
 
     def action_invoice_create(self, cursor, user, ids, journal_id=False,
             group=False, type='out_invoice', context=None):
+        if context is None:
+            context = {}
         invoice_obj = self.pool.get('account.invoice')
         picking_obj = self.pool.get('stock.picking')
         invoice_line_obj = self.pool.get('account.invoice.line')
+        fiscal_position_obj = self.pool.get('account.fiscal.position')
+        order_line_obj = self.pool.get('sale.order.line')
 
         result = super(stock_picking, self).action_invoice_create(cursor, user,
                 ids, journal_id=journal_id, group=group, type=type,
@@ -144,6 +148,8 @@
                 invoice_obj.write(cursor, user, [invoice_created.id], {'name': inv_name}, context=context)
             for sale_line in sale_lines:
                 if sale_line.product_id.type == 'service' and sale_line.invoiced == False:
+                    if not type:
+                        type = context.get('inv_type', False)
                     if group:
                         name = picking.name + '-' + sale_line.name
                     else:
@@ -168,7 +174,7 @@
                     account_analytic_id = self._get_account_analytic_invoice(cursor,
                             user, picking, sale_line)
 
-                    account_id = self.pool.get('account.fiscal.position').map_account(cursor, user, picking.sale_id.partner_id.property_account_position, account_id)
+                    account_id = fiscal_position_obj.map_account(cursor, user, picking.sale_id.partner_id.property_account_position, account_id)
                     invoice = invoices[result[picking.id]]
                     invoice_line_id = invoice_line_obj.create(cursor, user, {
                         'name': name,
@@ -183,7 +189,7 @@
                         'account_analytic_id': account_analytic_id,
                         'notes':sale_line.notes
                     }, context=context)
-                    self.pool.get('sale.order.line').write(cursor, user, [sale_line.id], {'invoiced': True,
+                    order_line_obj.write(cursor, user, [sale_line.id], {'invoiced': True,
                         'invoice_lines': [(6, 0, [invoice_line_id])],
                     })
         return result