Merge lp:~openerp-dev/openobject-addons/trunk-bug-740596-ara into lp:openobject-addons

[Ashvin Rathod (OpenERP)]

Hello,

FIX: #740596 payment term line need at least 5 to 6 digits precision

Thanks,
ara

[xrg (xrg)]

On Friday 25 March 2011, you wrote:
> Ashvin Rathod (OpenERP) has proposed merging
> lp:~openerp-dev/openobject-addons/trunk-bug-740596-ara into
> lp:openobject-addons.
>

There is something I don't like there: Aren't all these precision settings
supposed to be configurable through the "decimal_precision"?
Is it correct to hard-code values there?

--
Say NO to spam and viruses. Stop using Microsoft Windows!

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

I agree with xrg we can not have hard coded values for precision.

review: Needs Fixing

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

Hello,

I have changed as per xrg suggestion.

Thank you,
ara

review: Needs Resubmitting

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

review: Approve

=== modified file 'account/account.py'
--- account/account.py	2011-04-19 10:45:57 +0000
+++ account/account.py	2011-04-27 07:07:18 +0000
@@ -102,7 +102,7 @@
                                    ('fixed', 'Fixed Amount')], 'Valuation',
                                    required=True, help="""Select here the kind of valuation related to this payment term line. Note that you should have your last line with the type 'Balance' to ensure that the whole amount will be threated."""),
 
-        'value_amount': fields.float('Value Amount', help="For Value percent enter % ratio between 0-1."),
+        'value_amount': fields.float('Value Amount', digits_compute=dp.get_precision('Payment Term'), help="For Value percent enter % ratio between 0-1."),
         'days': fields.integer('Number of Days', required=True, help="Number of days to add before computation of the day of month." \
             "If Date=15/01, Number of Days=22, Day of Month=-1, then the due date is 28/02."),
         'days2': fields.integer('Day of the Month', required=True, help="Day of the month, set -1 for the last day of the current month. If it's positive, it gives the day of the next month. Set 0 for net days (otherwise it's based on the beginning of the month)."),

=== modified file 'account/data/account_data2.xml'
--- account/data/account_data2.xml	2011-02-03 10:16:30 +0000
+++ account/data/account_data2.xml	2011-04-27 07:07:18 +0000
@@ -21,7 +21,10 @@
             <field eval="-1" name="days2"/>
             <field eval="account_payment_term" name="payment_id"/>
         </record>
-
+        <record forcecreate="True" id="decimal_payment" model="decimal.precision">
+            <field name="name">Payment Term</field>
+            <field name="digits">6</field>
+        </record>
         <!--
         Account Journal View
         -->