Merge lp:~openerp-dev/openobject-addons/trunk-bug-740353-ara into lp:openobject-addons

[Ashvin Rathod (OpenERP)]

Hello,

Fix: #740353 [account] dog slow invoice cancel because validate for every line; patch included

Thanks,
ara

[Olivier Dony (Odoo) (odo-openerp)]

Hello, there is a set() object for efficiently maintaining lists without duplicates.

review: Needs Fixing

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

hello,

I have changed as Olivier Dony(OpenERP) suggestion.

Thanks,
ara

review: Needs Resubmitting

[qdp (OpenERP) (qdp)]

i commited in that branch how to properly use the set type. Please have a look Ashvin. By the way, why don't i see Mustufa as reviewer?

Anyway, i merged this branch with my fix

=== modified file 'account/account_move_line.py'
--- account/account_move_line.py	2011-03-03 14:59:00 +0000
+++ account/account_move_line.py	2011-03-25 15:41:30 +0000
@@ -1087,12 +1087,15 @@
         move_obj = self.pool.get('account.move')
         self._update_check(cr, uid, ids, context)
         result = False
+        move_ids = set()
         for line in self.browse(cr, uid, ids, context=context):
+            move_ids.add(line.move_id.id)
             context['journal_id'] = line.journal_id.id
             context['period_id'] = line.period_id.id
             result = super(account_move_line, self).unlink(cr, uid, [line.id], context=context)
-            if check:
-                move_obj.validate(cr, uid, [line.move_id.id], context=context)
+        move_ids = list(move_ids)
+        if check and move_ids:
+            move_obj.validate(cr, uid, move_ids, context=context)
         return result
 
     def _check_date(self, cr, uid, vals, context=None, check=True):