Merge lp:~openerp-dev/openobject-addons/trunk-bug-733143-rpa into lp:openobject-addons

Proposed by Rucha (Open ERP)
Status: Merged
Merged at revision: 4576
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-733143-rpa
Merge into: lp:openobject-addons
Diff against target: 20 lines (+2/-1)
1 file modified
product/pricelist.py (+2/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-733143-rpa
Reviewer Review Type Date Requested Status
OpenERP buildbot (community) Disapprove
qdp (OpenERP) Pending
Review via email: mp+53237@code.launchpad.net
To post a comment you must log in.
Revision history for this message
OpenERP buildbot (openerp-buildbot) wrote :

hr_evaluation/test/test_hr_evaluation.yml: ('warning', 'Warning !')
point_of_sale/test/point_of_sale_test.yml: 'item_id'
crm_partner_assign/test/test_crm_partner_assign.yml[warning]: AssertionError in Python code : SMTP not configured !
project_timesheet/test/worktask_entry_to_timesheetline_entry.yml[warning]: Assertion "After hr manager's work task" FAILED test: len(timesheet_ids) > 0 values: ! 0 > 0
~/addons/anonymization/anonymization.py:298[pywarn]: The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead.

review: Disapprove
Revision history for this message
OpenERP buildbot (openerp-buildbot) wrote :

hr_evaluation/test/test_hr_evaluation.yml: ('warning', 'Warning !')
crm_partner_assign/test/test_crm_partner_assign.yml[warning]: AssertionError in Python code : SMTP not configured !
project_timesheet/test/worktask_entry_to_timesheetline_entry.yml[warning]: Assertion "After hr manager's work task" FAILED test: len(timesheet_ids) > 0 values: ! 0 > 0
~/addons/anonymization/anonymization.py:298[pywarn]: The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead.
~/addons/anonymization/anonymization.py:300[pywarn]: The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'product/pricelist.py'
2--- product/pricelist.py 2011-03-09 16:05:32 +0000
3+++ product/pricelist.py 2011-03-15 08:51:05 +0000
4@@ -284,6 +284,7 @@
5 price = False
6
7 if price:
8+ results['item_id'] = res['id']
9 if 'uom' in context and not uom_price_already_computed:
10 product = products_dict[product_id]
11 uom = product.uos_id or product.uom_id
12@@ -299,7 +300,7 @@
13 def price_get(self, cr, uid, ids, prod_id, qty, partner=None, context=None):
14 res_multi = self.price_get_multi(cr, uid, pricelist_ids=ids, products_by_qty_by_partner=[(prod_id, qty, partner)], context=context)
15 res = res_multi[prod_id]
16- res.update({'item_id': {ids[-1]: ids[-1]}})
17+ res.update({'item_id': {ids[-1]: res_multi.get('item_id', ids[-1])}})
18 return res
19
20 def price_get_old(self, cr, uid, ids, prod_id, qty, partner=None, context=None):

Subscribers

People subscribed via source and target branches

to all changes: