Merge lp:~openerp-dev/openobject-addons/trunk-bug-727900-ara into lp:openobject-addons

[Ashvin Rathod (OpenERP)]

Hello,

Fix the bug: can not change stage in hr recruitment
https://bugs.launchpad.net/openobject-addons/+bug/727900

Thanks,
ara

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

you can use:

if not department_id:
   return {'value': {'stage_id': False}}

at the begining of the onchange method so that it will not make unnecessary pool.

review: Needs Fixing

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

hello,

I have changed as you describe above.

Thanks,
ara

review: Needs Resubmitting

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

review: Approve

=== modified file 'hr_recruitment/hr_recruitment.py'
--- hr_recruitment/hr_recruitment.py	2011-02-17 05:18:59 +0000
+++ hr_recruitment/hr_recruitment.py	2011-03-04 07:27:19 +0000
@@ -185,6 +185,14 @@
             return {'value': result}
         return {'value': {'department_id': False}}
 
+    def onchange_department_id(self, cr, uid, ids, department_id=False, context=None):
+        if not department_id:
+            return {'value': {'stage_id': False}}
+        obj_recru_stage = self.pool.get('hr.recruitment.stage')
+        stage_ids = obj_recru_stage.search(cr, uid, ['|',('department_id','=',department_id),('department_id','=',False)], context=context)
+        stage_id = stage_ids and stage_ids[0] or False
+        return {'value': {'stage_id': stage_id}}
+
     def stage_previous(self, cr, uid, ids, context=None):
         """This function computes previous stage for case from its current stage
              using available stage for that case type

=== modified file 'hr_recruitment/hr_recruitment_view.xml'
--- hr_recruitment/hr_recruitment_view.xml	2011-01-14 00:11:01 +0000
+++ hr_recruitment/hr_recruitment_view.xml	2011-03-04 07:27:19 +0000
@@ -80,7 +80,7 @@
                         <button string="Phone Call" name="%(action_hr_recruitment_phonecall)d" icon="terp-call-start" type="action" groups="base.group_extended"/>
                         <button name="action_makeMeeting" type="object" string="Meeting" icon="gtk-index"/>
                     <newline/>
-                    <field name="department_id" widget="selection"/>
+                    <field name="department_id" widget="selection" on_change="onchange_department_id(department_id)"/>
                     <group colspan="2" col="4">
                         <field name="stage_id" domain="[('department_id','=',department_id)]"/>
                         <button name="stage_previous" string="" type="object" icon="gtk-go-back"/>