Merge lp:~openerp-dev/openobject-addons/trunk-bug-718722-rha into lp:openobject-addons

Proposed by Rifakat Husen (OpenERP)
Status: Rejected
Rejected by: Rucha (Open ERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-718722-rha
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
mrp/mrp.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-718722-rha
Reviewer Review Type Date Requested Status
Rucha (Open ERP) (community) Disapprove
qdp (OpenERP) Needs Information
Review via email: mp+52161@code.launchpad.net

Description of the change

Bug #718722 mrp: raw material units should always be rounded up

To post a comment you must log in.
Revision history for this message
qdp (OpenERP) (qdp) wrote :

i don't see the point with the linked bug. Could someone explain?

review: Needs Information
Revision history for this message
Rucha (Open ERP) (rpa-openerp) wrote :

It was misinterpretation/misunderstanding actually, i have asked the person who assigned this bug for the reason. But it seems that there is an another problem,
found the actual problem,
rejecting it as the solution will be different,
thanks for the question!!

review: Disapprove

Unmerged revisions

4473. By Rifakat Husen (OpenERP)

[FIX] : mrp: raw material units should always be rounded up

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mrp/mrp.py'
2--- mrp/mrp.py 2011-02-15 12:50:01 +0000
3+++ mrp/mrp.py 2011-03-04 04:52:00 +0000
4@@ -447,7 +447,7 @@
5 'picking_id': fields.many2one('stock.picking', 'Picking list', readonly=True, ondelete="restrict",
6 help="This is the internal picking list that brings the finished product to the production plan"),
7 'move_prod_id': fields.many2one('stock.move', 'Move product', readonly=True),
8- 'move_lines': fields.many2many('stock.move', 'mrp_production_move_ids', 'production_id', 'move_id', 'Products to Consume', domain=[('state','not in', ('done', 'cancel'))], states={'done':[('readonly',True)]}),
9+ 'move_lines': fields.many2many('stock.move', 'mrp_production_move_ids', 'production_id', 'move_id', 'Products to Consume', domain=[('state','not in', ('done', 'cancel'))], readonly=True, states={'draft':[('readonly',False)]}),
10 'move_lines2': fields.many2many('stock.move', 'mrp_production_move_ids', 'production_id', 'move_id', 'Consumed Products', domain=[('state','in', ('done', 'cancel'))]),
11 'move_created_ids': fields.one2many('stock.move', 'production_id', 'Moves Created', domain=[('state','not in', ('done', 'cancel'))], states={'done':[('readonly',True)]}),
12 'move_created_ids2': fields.one2many('stock.move', 'production_id', 'Moves Created', domain=[('state','in', ('done', 'cancel'))]),

Subscribers

People subscribed via source and target branches

to all changes: