Merge lp:~openerp-dev/openobject-addons/trunk-bug-708073-psi into lp:openobject-addons

Proposed by Purnendu Singh (OpenERP)
Status: Rejected
Rejected by: Mustufa Rangwala (Open ERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-708073-psi
Merge into: lp:openobject-addons
Diff against target: 15 lines (+2/-2)
1 file modified
analytic/analytic.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-708073-psi
Reviewer Review Type Date Requested Status
Mustufa Rangwala (Open ERP) (community) Needs Fixing
qdp (OpenERP) Pending
Review via email: mp+56686@code.launchpad.net

Description of the change

Hello,

Fix: analytic account: view account.analytic.account.tree gives incorrect sum

Thanks
Purnendu Singh

To post a comment you must log in.
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

char of analytic accounts + analytic account menu => just show debit/credit/balance only in child row .. should also be reflect to parents.

review: Needs Fixing
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

i reject the merge its not solve the problem. we should fix it in better way.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'analytic/analytic.py'
2--- analytic/analytic.py 2011-03-24 11:12:12 +0000
3+++ analytic/analytic.py 2011-04-07 05:12:29 +0000
4@@ -37,9 +37,9 @@
5 res = recursive_computation(son.id, res)
6 for field in field_names:
7 if account.currency_id.id == son.currency_id.id or field=='quantity':
8- res[account.id][field] += res[son.id][field]
9+ res[account.id][field] = res[son.id][field]
10 else:
11- res[account.id][field] += currency_obj.compute(cr, uid, son.currency_id.id, account.currency_id.id, res[son.id][field], context=context)
12+ res[account.id][field] = currency_obj.compute(cr, uid, son.currency_id.id, account.currency_id.id, res[son.id][field], context=context)
13 return res
14 for account in self.browse(cr, uid, ids, context=context):
15 if account.id not in child_ids:

Subscribers

People subscribed via source and target branches

to all changes: