Merge lp:~openerp-dev/openobject-addons/trunk-bug-1227608-avo into lp:openobject-addons

Proposed by Amit Vora(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1227608-avo
Merge into: lp:openobject-addons
Diff against target: 42 lines (+14/-14)
1 file modified
email_template/email_template.py (+14/-14)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1227608-avo
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+187500@code.launchpad.net

Description of the change

Hello,
      I have add condition in loop to stop traceback when click on save as new template.
Thanks.
Amit.

To post a comment you must log in.

Unmerged revisions

8913. By Amit Vora(OpenERP)

[FIX] add condition in loop

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'email_template/email_template.py'
2--- email_template/email_template.py 2013-09-12 07:40:55 +0000
3+++ email_template/email_template.py 2013-09-25 12:34:10 +0000
4@@ -102,24 +102,24 @@
5
6 # prepare template variables
7 user = self.pool.get('res.users').browse(cr, uid, uid, context=context)
8- records = self.pool[model].browse(cr, uid, res_ids, context=context) or [None]
9 variables = {
10 'user': user,
11 'ctx': context, # context kw would clash with mako internals
12 }
13- for record in records:
14- res_id = record.id if record else None
15- variables['object'] = record
16- try:
17- render_result = template.render(variables)
18- except Exception:
19- _logger.exception("Failed to render template %r using values %r" % (template, variables))
20- render_result = u""
21- if render_result == u"False":
22- render_result = u""
23- results[res_id] = render_result
24- return results
25-
26+ for res_id in res_ids:
27+ if res_id:
28+ record = self.pool[model].browse(cr, uid, res_id, context=context)
29+ res_id = record.id if record else None
30+ variables['object'] = record
31+ try:
32+ render_result = template.render(variables)
33+ except Exception:
34+ _logger.exception("Failed to render template %r using values %r" % (template, variables))
35+ render_result = u""
36+ if render_result == u"False":
37+ render_result = u""
38+ results[res_id] = render_result
39+ return results
40 def get_email_template_batch(self, cr, uid, template_id=False, res_ids=None, context=None):
41 if context is None:
42 context = {}

Subscribers

People subscribed via source and target branches

to all changes: