Merge lp:~openerp-dev/openobject-addons/trunk-bug-1204455-ssh into lp:openobject-addons

[Sunil Sharma(OpenERP)]

Hello,

       I have fix this bug, Employee personal address should be private information in hr.

Thanks
Sunil Sharma (SSH)

[Daniel Reis (dreis-pt)]

The Record Rule is a good solution, but there is a use case that will not work:
Sometimes we have many2one field for res.partner that reference an OpenERP user.
For example: in Project Issues, we night wnat the "Contact" (partner_id) field to reference the Demo user.

I suggest using for the record rule:
<field name="domain_force">[('employee','=',False)] </field>

review: Needs Information

[lp:~openerp-dev/openobject-addons/trunk-bug-1204455-ssh]

9055. By Sunil Sharma(OpenERP) on 2014-01-17

[imp]:as per suggestion

9056. By Sunil Sharma(OpenERP) on 2014-01-20

[imp]:add write method

Unmerged revisions

9056. By Sunil Sharma(OpenERP) on 2014-01-20

[imp]:add write method

9055. By Sunil Sharma(OpenERP) on 2014-01-17

[imp]:as per suggestion

9054. By Sunil Sharma(OpenERP) on 2014-01-17

[FIX]:hr:personal address should be private information

=== modified file 'hr/hr.py'
--- hr/hr.py	2013-12-12 09:32:34 +0000
+++ hr/hr.py	2014-01-20 05:33:20 +0000
@@ -252,6 +252,14 @@
         )
         return employee_id
 
+    def write(self, cr, uid, ids, vals, context=None):
+        """Overrides orm write method
+        """
+        if 'address_home_id' in vals:
+            if vals['address_home_id']:
+                self.pool.get('res.partner').write(cr, uid, vals['address_home_id'], {'employee': True})
+        return super(hr_employee, self).write(cr, uid, ids, vals, context=context)
+
     def unlink(self, cr, uid, ids, context=None):
         resource_ids = []
         for employee in self.browse(cr, uid, ids, context=context):

=== modified file 'hr/hr_view.xml'
--- hr/hr_view.xml	2013-12-12 09:32:34 +0000
+++ hr/hr_view.xml	2014-01-20 05:33:20 +0000
@@ -67,7 +67,7 @@
                                         <field name="otherid" groups="base.group_hr_user"/>
                                     </group>
                                     <group string="Contact Information">
-                                        <field name="address_home_id" context="{'show_address': 1}" options='{"always_reload": True, "highlight_first_line": True}'/>
+                                        <field name="address_home_id"  context="{'show_address': 1,'default_customer':0, 'default_supplier':0, 'default_employee':1}" options='{"always_reload": True, "highlight_first_line": True}'/>
                                     </group>
                                     <group string="Status">
                                         <field name="gender"/>
@@ -95,6 +95,8 @@
             </field>
         </record>
 
+
+
         <record id="view_employee_tree" model="ir.ui.view">
             <field name="name">hr.employee.tree</field>
             <field name="model">hr.employee</field>

=== modified file 'hr/security/hr_security.xml'
--- hr/security/hr_security.xml	2013-10-27 12:31:04 +0000
+++ hr/security/hr_security.xml	2014-01-20 05:33:20 +0000
@@ -35,6 +35,12 @@
         <field eval="True" name="global"/>
         <field name="domain_force">['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]</field>
     </record>
+    <record id="hr_employee_address" model="ir.rule">
+        <field name="name">hr employee address rule</field>
+        <field name="model_id" ref="base.model_res_partner"/>
+        <field name="domain_force">[('employee','=',False)] </field>
+        <field name="groups" eval="[(4, ref('base.group_user'))]"/>
+    </record>
 
 </data>
 </openerp>