Merge lp:~openerp-dev/openobject-addons/trunk-bug-1190185-dharmraj into lp:openobject-addons

[Dharmraj Zala(OpenERP)]

Hello,

I have fixed this issue by adding appropriate validation/constraint on discount percentage on sale order line.

Thanks,
Dharmraj.

Unmerged revisions

8758. By Dharmraj Zala(OpenERP) on 2013-06-12

[FIX] Added Validation Constraint on discount percentage

=== modified file 'sale/sale.py'
--- sale/sale.py	2013-06-07 10:23:59 +0000
+++ sale/sale.py	2013-06-12 12:02:31 +0000
@@ -690,6 +690,12 @@
                                                   sale_order_line sol ON (sol.order_id = rel.order_id)
                                     WHERE rel.invoice_id = ANY(%s)""", (list(ids),))
         return [i[0] for i in cr.fetchall()]
+        
+    def _check_discount(self, cr, uid, ids, context=None):
+        for soline in self.browse(cr, uid, ids,context=context):
+            if soline.discount < 0.0 or soline.discount > 100.00:
+                return False
+        return True   
 
     _name = 'sale.order.line'
     _description = 'Sales Order Line'
@@ -736,6 +742,8 @@
         'type': 'make_to_stock',
         'price_unit': 0.0,
     }
+    
+    _constraints = [(_check_discount,'Error! \n Enter Valid Discount (Between 0.0 to 100.0).',['discount']),]
 
     def _get_line_qty(self, cr, uid, line, context=None):
         if (line.order_id.invoice_quantity=='order'):