Merge lp:~openerp-dev/openobject-addons/trunk-bug-1173102-ssh into lp:openobject-addons

Proposed by Sunil Sharma(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1173102-ssh
Merge into: lp:openobject-addons
Diff against target: 13 lines (+1/-2)
1 file modified
account/account.py (+1/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1173102-ssh
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) (community) code review Needs Fixing
Pedro Manuel Baeza (community) code review and test Approve
OpenERP Core Team Pending
Review via email: mp+205691@code.launchpad.net

Description of the change

Hello,

       I have fix this bug, Product price change when taxes are included in price in account.

Thanks
Sunil Sharma (SSH)

To post a comment you must log in.
9087. By Niko (OpenERP)

[IMP] Add some video to manisfest ( website, website_blog, website_event, website_ecommerce)

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, I have tested your patch and it's working as intended.

Thank you very much.

review: Approve (code review and test)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

I don't think we should always ignore the precision passed to _compute. The problem seems to be caused by http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/view/head:/account/account.py#L2144, so better fix it there.

review: Needs Fixing (code review)

Unmerged revisions

9126. By Sunil Sharma(OpenERP)

[fix]:set the equally precision

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account.py'
2--- account/account.py 2014-01-29 18:47:03 +0000
3+++ account/account.py 2014-02-11 04:46:23 +0000
4@@ -2278,8 +2278,7 @@
5 tax = {'name':'', 'amount':0.0, 'account_collected_id':1, 'account_paid_id':2}
6 one tax for each tax id in IDS and their children
7 """
8- if not precision:
9- precision = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
10+ precision = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
11 res = self._unit_compute_inv(cr, uid, taxes, price_unit, product, partner=None)
12 total = 0.0
13 for r in res:

Subscribers

People subscribed via source and target branches

to all changes: