Merge lp:~openerp-dev/openobject-addons/trunk-bug-1172156-sejal into lp:openobject-addons

Proposed by Sejal Bhut(OpenERP Trainee)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1172156-sejal
Merge into: lp:openobject-addons
Diff against target: 11 lines (+1/-1)
1 file modified
account/account.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1172156-sejal
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) (community) Disapprove
Amit Parik (community) Disapprove
OpenERP Core Team Pending
Review via email: mp+166648@code.launchpad.net

Description of the change

Hello,

 I have solved the problem of format_layout from model res.partner.bank.type must not be translated.
Thanks,
Sejal

To post a comment you must log in.
Revision history for this message
Sejal Bhut(OpenERP Trainee) (sejal.bhut-openerp-deactivatedaccount) wrote :

Hello,

    I have solved the problem of format_layout from model res.partner.bank.type must not be translated.

Thanks,
sejal

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Sejal,

I don't think you correctly undertstand the bug report because you have removed the translate=True from the name field Account Type. This account type is a user defined account type. It mainly used for Deferral method (opening entry for new fiscal year) and also effect on BS and P&L reports.As I said its user defined account type so translation is required there.

Here on bug report Yaan is talking about the res.partner.bank.type object not the account.account.type.

Thank you!

review: Disapprove
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I agree with Amit Parik that this is not the correct field. Instead, try the format_layout field in openobject-server/openerp/addons/base/res/res_bank.py.

review: Disapprove

Unmerged revisions

8727. By Sejal Bhut(OpenERP Trainee)

[FIX] Remove translate=true from Account Type field

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account.py'
2--- account/account.py 2013-04-29 15:14:10 +0000
3+++ account/account.py 2013-05-31 05:16:36 +0000
4@@ -175,7 +175,7 @@
5 return obj_financial_report.write(cr, uid, [financial_report_ref[field_value].id], {'account_type_ids': [(4, account_type_id)]})
6
7 _columns = {
8- 'name': fields.char('Account Type', size=64, required=True, translate=True),
9+ 'name': fields.char('Account Type', size=64, required=True),
10 'code': fields.char('Code', size=32, required=True, select=True),
11 'close_method': fields.selection([('none', 'None'), ('balance', 'Balance'), ('detail', 'Detail'), ('unreconciled', 'Unreconciled')], 'Deferral Method', required=True, help="""Set here the method that will be used to generate the end of year journal entries for all the accounts of this type.
12

Subscribers

People subscribed via source and target branches

to all changes: