Merge lp:~openerp-dev/openobject-addons/trunk-bug-1149676-dharmraj into lp:openobject-addons

[Dharmraj Zala(OpenERP)]

Hello,

  I have changed the code as per your suggestion.

Thanks,
Dharmraj.

[Numérigraphe (numerigraphe)]

Thanks,
It needs improvements:
Code: you must check whether defaults is None or not.
Style: please watch out for the spaces (no double space, space before+after '=' in assignments...), see PEP8.
Lionel Sausin

review: Needs Fixing

[Serpent Consulting Services (serpent-consulting-services)]

The code should say:

default['crossovered_budget_line'] = [] #not a dictionary

Thanks.

review: Needs Fixing

[Cristian Salamea (ovnicraft)]

Hello this MP solves the problem just for account duplicated but not for all childs, check it please, the same redefinition exists in analytic module: http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/view/head:/analytic/analytic.py#L264

I suggest clear in childs too.

review: Needs Fixing

Unmerged revisions

8620. By Dharmraj Zala(OpenERP) on 2013-03-22

[MERGE] with trunk

8619. By Dharmraj Zala(OpenERP) on 2013-03-20

[IMP] improvement in returning value

8618. By Dharmraj Zala(OpenERP) on 2013-03-20

[MERGE] merge with addons

8617. By Dharmraj Zala(OpenERP) on 2013-03-18

[IMP] assigned blank list instead of dictionary

8616. By Dharmraj Zala(OpenERP) on 2013-03-13

[IMP] added condition whether default is None or not

8615. By Dharmraj Zala(OpenERP) on 2013-03-13

[FIX] overrid the copy method of account_analytic_account

=== modified file 'account_budget/account_budget.py'
--- account_budget/account_budget.py	2012-12-17 15:23:03 +0000
+++ account_budget/account_budget.py	2013-03-22 11:35:35 +0000
@@ -210,6 +210,13 @@
     _columns = {
         'crossovered_budget_line': fields.one2many('crossovered.budget.lines', 'analytic_account_id', 'Budget Lines'),
     }
+    def copy(self, cr, uid, id, default=None, context=None):
+        if context is None:
+            context = {}
+        if default is None:
+            default = {}
+        default['crossovered_budget_line'] = []
+        return  super(account_analytic_account, self).copy(cr, uid, id, default=default, context=context)
 
 account_analytic_account()