Merge lp:~openerp-dev/openobject-addons/trunk-bug-1116854-amee into lp:openobject-addons

[Amee Sankhesara(OpenERP Trainee)]

Hello,

When Reactivate Task, state are not changed.it remains in done state because of that progress bar remain 100%.
so change state to open when reactivate task.

Thanks.

[Atul Patel(OpenERP) (atp-openerp)]

Hello,

It's work.

Thanks for your good work..!!

review: Approve

[Serpent Consulting Services (serpent-consulting-services)]

Correction AFAIK,

There is no need for multiple lines here, and also for the 'project = task.project_id' line !

This should do:

"
def do_reopen(self, cr, uid, ids, context=None):
    return self.case_set(cr, uid, ids, 'open', {}, context=context)
"

Is the {'state': 'open'} phrase needed when state is related to stage_id ?

Kindly correct if misunderstood!

Thanks.

review: Needs Fixing

[Atul Patel(OpenERP) (atp-openerp)]

Hello,

Thanks Serpent consulting for correction.

Instead of this {'state': 'open'} phrase , I think Need to pass 'stage_id' in 'progress' function field
store like this :

store = {
                'project.task': (lambda self, cr, uid, ids, c={}: ids, ['work_ids', 'remaining_hours', 'planned_hours','stage_id'], 10),
              ....

            }),

so when we reactivate task , progress bar are updated.

Correct me if I am wrong..

Thanks

[Serpent Consulting Services (serpent-consulting-services)]

Atul,

It's rare you are wrong as you see!

Not sure what's plan but I feel the 4th param 'open' will affect the stage+state!

Thanks.

Unmerged revisions

8565. By Amee Sankhesara(OpenERP Trainee) on 2013-02-22

[FIX]: Change state to open when reevaluate task.

=== modified file 'project/project.py'
--- project/project.py	2013-02-26 20:40:22 +0000
+++ project/project.py	2013-03-01 10:33:24 +0000
@@ -968,7 +968,8 @@
     def do_reopen(self, cr, uid, ids, context=None):
         for task in self.browse(cr, uid, ids, context=context):
             project = task.project_id
-            self.case_set(cr, uid, [task.id], 'open', {}, context=context)
+            #When Reevaluation Task, Need to change state to open.
+            self.case_set(cr, uid, [task.id], 'open', {'state': 'open'}, context=context)
         return True
 
     def do_cancel(self, cr, uid, ids, context=None):