Merge lp:~openerp-dev/openobject-addons/trunk-bug-1111430-nco into lp:openobject-addons

[Nimesh Contractor(Open ERP)]

Hello,

Fix account invoice line fields_view_get is broken.
As the purchase_ok field is in purchase module and sale_ok field is in sale module so remove the fields view get form the account invoice line and set in purchase for type 'in_invoice', 'in_refund' also in sale for type 'out_invoice' and 'out_refund'.

Thank You!

Unmerged revisions

8709. By Ishwar Malvi(OpenERP) on 2013-05-22

[FIX] as the purchase ok field is in purchase and sale_ok in sale module so remove unuesed fields view get and set in purchase and sale module.

=== modified file 'account/account_invoice.py'
--- account/account_invoice.py	2013-04-22 15:34:49 +0000
+++ account/account_invoice.py	2013-05-22 05:43:27 +0000
@@ -1402,20 +1402,6 @@
         'account_id': _default_account_id,
     }
 
-    def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
-        if context is None:
-            context = {}
-        res = super(account_invoice_line,self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar, submenu=submenu)
-        if context.get('type', False):
-            doc = etree.XML(res['arch'])
-            for node in doc.xpath("//field[@name='product_id']"):
-                if context['type'] in ('in_invoice', 'in_refund'):
-                    node.set('domain', "[('purchase_ok', '=', True)]")
-                else:
-                    node.set('domain', "[('sale_ok', '=', True)]")
-            res['arch'] = etree.tostring(doc)
-        return res
-
     def product_id_change(self, cr, uid, ids, product, uom_id, qty=0, name='', type='out_invoice', partner_id=False, fposition_id=False, price_unit=False, currency_id=False, context=None, company_id=None):
         if context is None:
             context = {}

=== modified file 'purchase/purchase.py'
--- purchase/purchase.py	2013-04-15 10:23:49 +0000
+++ purchase/purchase.py	2013-05-22 05:43:27 +0000
@@ -20,6 +20,7 @@
 ##############################################################################
 
 import time
+from lxml import etree
 import pytz
 from openerp import SUPERUSER_ID
 from datetime import datetime
@@ -1243,6 +1244,19 @@
         if po_ids:
             purchase_order_obj.message_post(cr, uid, po_ids, body=_("Invoice paid"), context=context)
         return res
-
+class account_invoice_line(osv.Model):
+    _inherit = 'account.invoice.line'
+    
+    def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
+        if context is None:
+            context = {}
+        res = super(account_invoice_line,self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar, submenu=submenu)
+        if context.get('type', False):
+            doc = etree.XML(res['arch'])
+            for node in doc.xpath("//field[@name='product_id']"):
+                if context['type'] in ('in_invoice', 'in_refund'):
+                    node.set('domain', "[('purchase_ok', '=', True)]")
+            res['arch'] = etree.tostring(doc)
+        return res
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== modified file 'sale/sale.py'
--- sale/sale.py	2013-04-22 15:34:49 +0000
+++ sale/sale.py	2013-05-22 05:43:27 +0000
@@ -19,6 +19,7 @@
 #
 ##############################################################################
 
+from lxml import etree
 from datetime import datetime, timedelta
 from dateutil.relativedelta import relativedelta
 import time
@@ -1032,4 +1033,19 @@
                 wf_service.trg_validate(uid, 'account.invoice', id, 'invoice_cancel', cr)
         return super(account_invoice, self).unlink(cr, uid, ids, context=context)
 
+class account_invoice_line(osv.Model):
+    _inherit = 'account.invoice.line'
+    
+    def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
+        if context is None:
+            context = {}
+        res = super(account_invoice_line,self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar, submenu=submenu)
+        if context.get('type', False):
+            doc = etree.XML(res['arch'])
+            for node in doc.xpath("//field[@name='product_id']"):
+                if context['type'] in ('out_invoice', 'out_refund'):
+                    node.set('domain', "[('sale_ok', '=', True)]")
+            res['arch'] = etree.tostring(doc)
+        return res
+
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: