Merge lp:~openerp-dev/openobject-addons/trunk-bug-1104155-nco into lp:openobject-addons

Proposed by Nimesh Contractor(Open ERP)
Status: Rejected
Rejected by: Thibault Delavallée (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1104155-nco
Merge into: lp:openobject-addons
Diff against target: 13 lines (+1/-2)
1 file modified
project/project.py (+1/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1104155-nco
Reviewer Review Type Date Requested Status
Nhomar - Vauxoo (community) Approve
Ajay Patel (OpenERP) (community) Approve
OpenERP Core Team Pending
Review via email: mp+146355@code.launchpad.net

This proposal supersedes a proposal from 2013-01-30.

Description of the change

Hello,

 Remove search domain to show empty stages, and easily moving a task to the next stage.

Thanks,
Nimesh.

To post a comment you must log in.
Revision history for this message
Ajay Patel (OpenERP) (ajay-openerp) wrote : Posted in a previous version of this proposal

Hello Nimesh

sorry but you did wrong fix.

it will crash when tasks open from project form view or kanban view.

can you please check it ?

Thanks,
Amit

review: Needs Fixing
8526. By Nimesh Contractor(Open ERP)

[MERGE] merge with trunk.

8527. By Nimesh Contractor(Open ERP)

[MERGE] with trunk

Revision history for this message
Ajay Patel (OpenERP) (ajay-openerp) :
review: Approve
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

The current behavior about folding empty stages is intended. I therefore reject this branch.

Best regards,

Revision history for this message
Nhomar - Vauxoo (nhomar) wrote :

Sorry i think it is a bug.

Mor info in the bug.

review: Approve

Unmerged revisions

8527. By Nimesh Contractor(Open ERP)

[MERGE] with trunk

8526. By Nimesh Contractor(Open ERP)

[MERGE] merge with trunk.

8525. By Nimesh Contractor(Open ERP)

[FIX] show all stages.

8524. By Nimesh Contractor(Open ERP)

[FIX] show all task stages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'project/project.py'
2--- project/project.py 2013-01-15 10:03:53 +0000
3+++ project/project.py 2013-02-15 07:34:24 +0000
4@@ -605,8 +605,7 @@
5 search_domain = []
6 project_id = self._resolve_project_id_from_context(cr, uid, context=context)
7 if project_id:
8- search_domain += ['|', ('project_ids', '=', project_id)]
9- search_domain += [('id', 'in', ids)]
10+ search_domain += [('project_ids', '=', project_id)]
11 stage_ids = stage_obj._search(cr, uid, search_domain, order=order, access_rights_uid=access_rights_uid, context=context)
12 result = stage_obj.name_get(cr, access_rights_uid, stage_ids, context=context)
13 # restore order of the search

Subscribers

People subscribed via source and target branches

to all changes: