Merge lp:~openerp-dev/openobject-addons/trunk-bug-1098440-hip into lp:openobject-addons

Proposed by Hiral Patel (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1098440-hip
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
project_mrp/project_procurement.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1098440-hip
Reviewer Review Type Date Requested Status
Ajay Patel (OpenERP) (community) Approve
Hiral Patel (OpenERP) (community) Needs Resubmitting
OpenERP Core Team Pending
Review via email: mp+145358@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ajay Patel (OpenERP) (ajay-openerp) wrote :

Hello ,

you just added whole description. but it should be good if you add first line of description like in note kanban view.

Thanks,
Amit

review: Needs Fixing
8524. By Hiral Patel (OpenERP)

[IMP] Improve the code

Revision history for this message
Hiral Patel (OpenERP) (hip-openerp) wrote :

Hello,

I have improved the code as per suggestion.

Thanks,
HIP

review: Needs Resubmitting
Revision history for this message
Ajay Patel (OpenERP) (ajay-openerp) :
review: Approve

Unmerged revisions

8524. By Hiral Patel (OpenERP)

[IMP] Improve the code

8523. By Hiral Patel (OpenERP)

[trunk][FIX] Display product description in task instade of product name

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'project_mrp/project_procurement.py'
2--- project_mrp/project_procurement.py 2012-12-21 16:48:08 +0000
3+++ project_mrp/project_procurement.py 2013-01-30 12:39:21 +0000
4@@ -72,7 +72,7 @@
5 project = self._get_project(cr, uid, procurement, context=context)
6 planned_hours = self._convert_qty_company_hours(cr, uid, procurement, context=context)
7 task_id = project_task.create(cr, uid, {
8- 'name': '%s:%s' % (procurement.origin or '', procurement.product_id.name),
9+ 'name': '%s:%s' % (procurement.origin or '', procurement.name.split("\n")[0]),
10 'date_deadline': procurement.date_planned,
11 'planned_hours': planned_hours,
12 'remaining_hours': planned_hours,

Subscribers

People subscribed via source and target branches

to all changes: