Merge lp:~openerp-dev/openobject-addons/trunk-bug-1096809-bth into lp:openobject-addons

Proposed by Bhumi Thakkar (Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1096809-bth
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
mail/static/src/js/mail_followers.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1096809-bth
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+142266@code.launchpad.net

Description of the change

Hello,

   [General Web] Traceback when clicking on page arrows several times in a row

1. Go to e.g. Sales => Opportunities list view
2. Open a record
3. browse the records by quickly clicking on the pager arrows
Or
1. Go to Sales => Leads list view
2. Open record and click on create button

Observed: got error: Uncaught TypeError: Cannot read property 'message_subtype_data' of undefined in chrome
or in firefox TypeError: data[this.view.dataset.ids[0]] is undefined.

Video:
https://docs.google.com/open?id=0B7c_6dPUa6bcZFZ6MlRQUk9Zanc

Thanks.

To post a comment you must log in.
Revision history for this message
Niels Huylebroeck (red15) wrote :

The fix is good but this only applies for trunk, I've backported this issue as close to the original change date and requested a merge from this branch, it should be easier to apply to both trunk and v7.0 versions.

The merge request I'd like to see (for both v7.0 and trunk) is here : https://code.launchpad.net/~openerp-community/openobject-addons/fix-mail_followers-message_subtype_data/+merge/142288

Revision history for this message
Niels Huylebroeck (red15) wrote :

Ignore last comment, seems there was other changes which caused conflicts on nearby lines.

Unmerged revisions

8495. By Bhumi Thakkar (Open ERP)

[FIX] Fixed issue: message_subtype_data of undefined.--fixes:lp1096809

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mail/static/src/js/mail_followers.js'
2--- mail/static/src/js/mail_followers.js 2012-12-27 10:37:01 +0000
3+++ mail/static/src/js/mail_followers.js 2013-01-08 09:10:28 +0000
4@@ -217,7 +217,7 @@
5 var self = this;
6 var subtype_list_ul = this.$('.oe_subtype_list');
7 subtype_list_ul.empty();
8- var records = data[this.view.datarecord.id || this.view.dataset.ids[0]].message_subtype_data;
9+ _(data).each(function (i) {records = i.message_subtype_data;});
10 var nb_subtype = 0;
11 _(records).each(function (record) {nb_subtype++;});
12 if (nb_subtype > 1) {

Subscribers

People subscribed via source and target branches

to all changes: