Merge lp:~openerp-dev/openobject-addons/trunk-bug-1096439-hip into lp:openobject-addons

Proposed by Hiral Patel (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1096439-hip
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
account/account.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1096439-hip
Reviewer Review Type Date Requested Status
Phil Frost (community) Disapprove
OpenERP Core Team Pending
Review via email: mp+142071@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Phil Frost (bitglue) wrote :

This is an incomplete fix. Does a user know what "a property" is? Even if they do, how would they know which object's proprerty is referencing the account they are attempting to delete? This error isn't actionable or useful. It might as well be "you can't do that because there was a problem."

review: Disapprove

Unmerged revisions

8496. By Hiral Patel (OpenERP)

[IMP] Improve code

8495. By Hiral Patel (OpenERP)

[trunk][FIX] You cannot remove/deactivate an account which is set on a customer or supplier

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account.py'
2--- account/account.py 2012-12-19 11:34:13 +0000
3+++ account/account.py 2013-01-07 09:04:21 +0000
4@@ -638,7 +638,7 @@
5 value = 'account.account,' + str(ids[0])
6 partner_prop_acc = self.pool.get('ir.property').search(cr, uid, [('value_reference','=',value)], context=context)
7 if partner_prop_acc:
8- raise osv.except_osv(_('Warning!'), _('You cannot remove/deactivate an account which is set on a customer or supplier.'))
9+ raise osv.except_osv(_('Warning!'), _('You cannot remove/deactivate an account which is set as a property.'))
10 return True
11
12 def _check_allow_type_change(self, cr, uid, ids, new_type, context=None):

Subscribers

People subscribed via source and target branches

to all changes: