Merge lp:~openerp-dev/openobject-addons/trunk-bug-1090224 into lp:openobject-addons

[Dharmang Soni (OpenERP)]

When department of employee is changed the leave stores old department id

[Michael Telahun Makonnen (mmakonnen)]

Hi there,

I believe that for related and function fields unless you store the value in the database you cannot search or filter on it. So, in this case instead of just setting store=False it might be better to use store={...}

See here for an example: http://doc.openerp.com/v6.0/developer/2_5_Objects_Fields_Methods/field_type.html#store-parameter

[Jose Antonio Morales Ponce(vauxoo) - - http://www.vauxoo.com (josemoralesp)]

Hi

To search on function fields you need make a fnct_search and return the
search parameters, without store=True
El 25/02/2013 09:46, "Michael Telahun Makonnen" <email address hidden>
escribió:

> Hi there,
>
> I believe that for related and function fields unless you store the value
> in the database you cannot search or filter on it. So, in this case
> instead of just setting store=False it might be better to use store={...}
>
> See here for an example:
> http://doc.openerp.com/v6.0/developer/2_5_Objects_Fields_Methods/field_type.html#store-parameter
>
> --
>
> https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-1090224/+merge/149980
> Your team OpenERP Community is subscribed to branch
> lp:~openerp-community/openobject-addons/trunk-bug-1090224.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-community
> More help : https://help.launchpad.net/ListHelp
>

[Michael Telahun Makonnen (mmakonnen)]

Ok. I hadn't thought of that.
My main point was that it should be searchable. Otherwise, it's broken.

Which way is the recommended way?
1. store=False and use fnct_search
    or
2. store={...} (and have the value in the db updated when the related
field changes).

I'm just wondering for my own future reference.

Regards,
Mike.

[Jose Antonio Morales Ponce(vauxoo) - - http://www.vauxoo.com (josemoralesp)]

Well it all depends on whether you want the record or field is not in the
db.

If you want the field will not save, store = False to be, it will make the
sensible and calculated field to display automatic, fnct_search there if
you need because there is being saved.

If you are using store = {model: method} the field is saved in the db and
calculated each time you have a change in the selected model, as this is
saved no need to use a fnct_search.

It's about what you need at that time, if you want to save the field or not
El 25/02/2013 10:26, "Michael Telahun Makonnen" <email address hidden>
escribió:

> Ok. I hadn't thought of that.
> My main point was that it should be searchable. Otherwise, it's broken.
>
> Which way is the recommended way?
> 1. store=False and use fnct_search
> or
> 2. store={...} (and have the value in the db updated when the related
> field changes).
>
> I'm just wondering for my own future reference.
>
> Regards,
> Mike.
>
> --
>
> https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-1090224/+merge/149980
> Your team OpenERP Community is subscribed to branch
> lp:~openerp-community/openobject-addons/trunk-bug-1090224.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-community
> More help : https://help.launchpad.net/ListHelp
>

[lp:~openerp-dev/openobject-addons/trunk-bug-1090224]

8547. By Dharmang Soni (OpenERP) on 2013-03-04

[MERGE] with trunk

Unmerged revisions

8547. By Dharmang Soni (OpenERP) on 2013-03-04

[MERGE] with trunk

8546. By Dharmang Soni (OpenERP) on 2013-02-22

merge with trunk

8545. By Dharmang Soni (OpenERP) on 2013-02-11

[FIX] hr_holiday : When department of employee is changed the leave stores old department id

=== modified file 'hr_holidays/hr_holidays.py'
--- hr_holidays/hr_holidays.py	2013-02-24 13:21:11 +0000
+++ hr_holidays/hr_holidays.py	2013-03-04 07:19:24 +0000
@@ -162,7 +162,7 @@
         'type': fields.selection([('remove','Leave Request'),('add','Allocation Request')], 'Request Type', required=True, readonly=True, states={'draft':[('readonly',False)], 'confirm':[('readonly',False)]}, help="Choose 'Leave Request' if someone wants to take an off-day. \nChoose 'Allocation Request' if you want to increase the number of leaves available for someone", select=True),
         'parent_id': fields.many2one('hr.holidays', 'Parent'),
         'linked_request_ids': fields.one2many('hr.holidays', 'parent_id', 'Linked Requests',),
-        'department_id':fields.related('employee_id', 'department_id', string='Department', type='many2one', relation='hr.department', readonly=True, store=True),
+        'department_id':fields.related('employee_id', 'department_id', string='Department', type='many2one', relation='hr.department', readonly=True, store=False),
         'category_id': fields.many2one('hr.employee.category', "Employee Tag", help='Category of Employee', readonly=True, states={'draft':[('readonly',False)], 'confirm':[('readonly',False)]}),
         'holiday_type': fields.selection([('employee','By Employee'),('category','By Employee Tag')], 'Allocation Mode', readonly=True, states={'draft':[('readonly',False)], 'confirm':[('readonly',False)]}, help='By Employee: Allocation/Request for individual Employee, By Employee Tag: Allocation/Request for group of employees in category', required=True),
         'manager_id2': fields.many2one('hr.employee', 'Second Approval', readonly=True, help='This area is automaticly filled by the user who validate the leave with second level (If Leave type need second validation)'),