Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/trunk-bug-1083077-kbh into lp:openobject-addons

  1. trunk-bug-1083077-kbh
  2. Merge into trunk
Proposed by Khushboo Bhatt(openerp)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1083077-kbh
Merge into: lp:openobject-addons
Diff against target: 11 lines (+1/-0)
1 file modified
sale_stock/sale_stock.py (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1083077-kbh
Reviewer Review Type Date Requested Status
Lionel Sausin - Initiatives/Numérigraphe (community) Disapprove
Alexandre Fayolle - camptocamp (community) code review, test Needs Fixing
OpenERP Core Team Pending
Review via email: mp+136643@code.launchpad.net

Description of the change

hello,

solved issue When you assign properties for a sale order line and confirm order, you don't find them on a related procurement.

thanks,
KBH

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

the property_ids field of procurement.order is added in mrp, which is not a dependency of sale_stock.

merging this fix causes WARNING in the tests (see https://bugs.launchpad.net/ocb-addons/+bug/1291903)

review: Needs Fixing (code review, test)
Reply
Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

OpenERP's Martin already fixed the bug the right way in v7 at revid:<email address hidden>
Please reject this proposal.

review: Disapprove
Reply

Unmerged revisions

8149. By Khushboo Bhatt(openerp)

[FIX]sale_stock:property_ids added

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_stock/sale_stock.py'
2--- sale_stock/sale_stock.py 2012-11-02 17:42:00 +0000
3+++ sale_stock/sale_stock.py 2012-11-28 12:43:21 +0000
4@@ -278,6 +278,7 @@
5 or line.product_uom.id,
6 'location_id': order.shop_id.warehouse_id.lot_stock_id.id,
7 'procure_method': line.type,
8+ 'property_ids': [(6, 0, [l.id for l in line.property_ids])],
9 'move_id': move_id,
10 'company_id': order.company_id.id,
11 'note': '\n'.join(line.name.split('\n')[1:])

Subscribers

People subscribed via source and target branches

to all changes: