Merge lp:~openerp-dev/openobject-addons/trunk-bug-1079548-sgo into lp:openobject-addons

[Sanjay Gohel (Open ERP)]

Hello,

       Increase message field size as per good coding convention.

Thank You.
Sanjay Gohel(SGO)

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

It fixes a bug with long messages, particularly useful when localized in a verbose language.

review: Approve

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

The commit does not have a link to the Launchpad bug number.
It would be nice to un-commit and re-commit with "--fixes"

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Quoting myself from the OCB's branch:

The size argument could be entirely removed, it is no longer required since the version 7.0.
It should be used when there is a reason to restrict the length of a field (e.g. ean13), there is no reason to do so here (varchar and text are the same thing under the hood, so the limitation won't bring better performance [0]).

Thanks

[0] http://stackoverflow.com/questions/4848964/postgresql-difference-between-text-and-varchar-character-varying

review: Needs Fixing

Unmerged revisions

8184. By Sanjay Gohel (Open ERP) on 2012-12-03

[IMP]increase message size as per coding convention

=== modified file 'procurement/procurement.py'
--- procurement/procurement.py	2012-11-02 17:34:07 +0000
+++ procurement/procurement.py	2012-12-03 06:09:21 +0000
@@ -103,7 +103,7 @@
             readonly=True, required=True, help="If you encode manually a Procurement, you probably want to use" \
             " a make to order method."),
         'note': fields.text('Note'),
-        'message': fields.char('Latest error', size=124, help="Exception occurred while computing procurement orders."),
+        'message': fields.char('Latest error', size=256, help="Exception occurred while computing procurement orders."),
         'state': fields.selection([
             ('draft','Draft'),
             ('cancel','Cancelled'),