Merge lp:~openerp-dev/openobject-addons/trunk-bug-1069681-kbh into lp:openobject-addons

Proposed by Khushboo Bhatt(openerp)
Status: Merged
Merged at revision: 8023
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1069681-kbh
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
mrp/mrp.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1069681-kbh
Reviewer Review Type Date Requested Status
Khushboo Bhatt(openerp) (community) Needs Resubmitting
Numérigraphe (community) Disapprove
OpenERP Core Team Pending
Review via email: mp+130963@code.launchpad.net

Description of the change

Hello,

  I have solved the issue of Names of components after duplicating a BOM.

Thanks,
KBH.

To post a comment you must log in.
Revision history for this message
Numérigraphe (numerigraphe) wrote :

You forgot to link your branch to the bug you fix.
Lionel

Revision history for this message
Numérigraphe (numerigraphe) wrote :

That change would make a copy without any line in it wouldn't it?
I don't think that's what the reporter asked for. Unless I'm mistaken, the problem is just that the suffix " Copy" is appended to the component names, and it should not be.
Lionel.

review: Disapprove
Revision history for this message
Khushboo Bhatt(openerp) (kbh-openerp) wrote :

Hello Lionel,

  I have removed suffix as per your comment.

Thanks,
KBH.

review: Needs Resubmitting
Revision history for this message
Numérigraphe (numerigraphe) wrote :

I think that's wrong again. The problem is in the nomenclature items, not the nomenclature itself.
Lionel

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mrp/mrp.py'
2--- mrp/mrp.py 2012-10-15 05:19:41 +0000
3+++ mrp/mrp.py 2012-10-23 10:29:22 +0000
4@@ -371,7 +371,7 @@
5 if default is None:
6 default = {}
7 bom_data = self.read(cr, uid, id, [], context=context)
8- default.update(name=_("%s (copy)") % (bom_data['name']), bom_id=False)
9+ default.update(name=_("%s") % (bom_data['name']), bom_id=False)
10 return super(mrp_bom, self).copy_data(cr, uid, id, default, context=context)
11
12 def create(self, cr, uid, vals, context=None):

Subscribers

People subscribed via source and target branches

to all changes: