Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/trunk-bug-1068822-cha into lp:openobject-addons

  1. trunk-bug-1068822-cha
  2. Merge into trunk
Proposed by Ajay Chauhan(OpenERP)
Status: Rejected
Rejected by: Olivier Dony (Odoo)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1068822-cha
Merge into: lp:openobject-addons
Diff against target: 19 lines (+2/-0)
1 file modified
l10n_fr_rib/bank_view.xml (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1068822-cha
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Review via email: mp+139640@code.launchpad.net

Description of the change

Hello,

 I have solved the following bug https://bugs.launchpad.net/openobject-addons/+bug/1068822
   l10n_fr_rib and error message when opening a Bank Account

Thanks,
Ajay Chauhan

To post a comment you must log in.
Revision history for this message
Quentin THEURET @Amaris (qtheuret) wrote :

The bug is still present on version 7.0 !

lp:~openerp-dev/openobject-addons/trunk-bug-1068822-cha updated
8296. By Ajay Chauhan(OpenERP)

[MERGE]: merge with main addons

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hi,

The state field should be added directly in the tree view of the res.partner.bank model, because it's the fields_get() method of res_partner_bank that causes the problem: sometimes it will create dynamic ``states`` attributes. That could very well happen even without l10n_fr_rib: just adding "acc_number" to the fields of the "Normal Bank account type" would cause it.

I'll fix it properly in the 7.0 branch and that will be ported to 7.0, thanks.

review: Disapprove

Unmerged revisions

8296. By Ajay Chauhan(OpenERP)

[MERGE]: merge with main addons

8295. By Ajay Chauhan(OpenERP)

[FIX] l10n_fr_rib: solved traceback on list view of bank account

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_fr_rib/bank_view.xml'
2--- l10n_fr_rib/bank_view.xml 2012-11-29 22:26:45 +0000
3+++ l10n_fr_rib/bank_view.xml 2012-12-31 09:09:24 +0000
4@@ -10,6 +10,7 @@
5 <data>
6 <xpath expr="//field[@name='bank_ids']/tree/field[@name='acc_number']" position="after">
7 <field name="rib_acc_number"/>
8+ <field name="state" invisible="1"/>
9 </xpath>
10 </data>
11 </field>
12@@ -40,6 +41,7 @@
13 <field name="arch" type="xml">
14 <field name="acc_number" position="after">
15 <field name="rib_acc_number" />
16+ <field name="state" invisible="1"/>
17 </field>
18 </field>
19 </record>

Subscribers

People subscribed via source and target branches

to all changes: