Merge lp:~openerp-dev/openobject-addons/trunk-bug-1021640-nco into lp:openobject-addons

[Nimesh Contractor(Open ERP)]

Hello,

      I have added constraint for the date.

Thanks,
 NCO.

[Atul Patel(OpenERP) (atp-openerp)]

Hello,

Good suggestion.there should be constraints for membership product.

Thanks.

review: Approve

[Fabien (Open ERP) (fp-tinyerp)]

I would suggest using a postgresql constraint for efficiency.

[lp:~openerp-dev/openobject-addons/trunk-bug-1021640-nco]

6999. By Cedric Snauwaert (OpenERP) on 2012-11-19

[MERGE]merge with latest addons

7000. By Cedric Snauwaert (OpenERP) on 2012-11-20

[FIX]fix constraint to an SQL constraint

[Cedric Snauwaert (OpenERP) (csn-openerp)]

Changed the constraint to a sql constraint and merged into trunk.

=== modified file 'membership/membership.py'
--- membership/membership.py	2012-08-14 14:10:40 +0000
+++ membership/membership.py	2012-08-22 12:18:42 +0000
@@ -478,7 +478,14 @@
         'membership_date_from': fields.date('Date from', help='Date from which membership becomes active.'),
         'membership_date_to': fields.date('Date to', help='Date until which membership remains active.'),
     }
-
+    def _check_end_date(self, cr, uid, ids, context=None):
+        for membership in self.browse(cr, uid, ids, context=context):
+            if membership.membership_date_to < membership.membership_date_from:
+                return False
+        return True
+    _constraints = [
+        (_check_end_date, 'Error ! Ending Date cannot be set before Beginning Date.', ['membership_date_to']),
+    ]
     _defaults = {
         'membership': False,
     }