Merge lp:~openerp-dev/openobject-addons/trunk-addons_issue12_hr-cha into lp:openobject-addons

Proposed by Ajay Chauhan(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-addons_issue12_hr-cha
Merge into: lp:openobject-addons
Diff against target: 117 lines (+43/-9)
6 files modified
hr/hr_view.xml (+12/-7)
hr_expense/security/ir.model.access.csv (+1/-0)
hr_holidays/hr_holidays_view.xml (+26/-0)
hr_recruitment/hr_recruitment_view.xml (+1/-1)
hr_timesheet_invoice/hr_timesheet_invoice.py (+2/-0)
hr_timesheet_sheet/wizard/hr_timesheet_current.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-addons_issue12_hr-cha
Reviewer Review Type Date Requested Status
Purnendu Singh (OpenERP) (community) Approve
Review via email: mp+126669@code.launchpad.net

Description of the change

Hello,

   I have made changes to solve the issues of addons12.

Thanks,
Ajay Chauhan

To post a comment you must log in.
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Seems Ok

Thanks,
Purnendu Singh

review: Approve
7552. By Ajay Chauhan(OpenERP)

[IMP] hr, hr_recruitment: made changes in form view

7553. By Ajay Chauhan(OpenERP)

[MERGE] merge with lp:openobject-addons

7554. By Ajay Chauhan(OpenERP)

[MERGE] merge with lp:openobject-addons

7555. By Ajay Chauhan(OpenERP)

[MERGE] merge with lp:openobject-addons

7556. By Ajay Chauhan(OpenERP)

[MERGE] merge with lp:openobject-addons

Unmerged revisions

7556. By Ajay Chauhan(OpenERP)

[MERGE] merge with lp:openobject-addons

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr/hr_view.xml'
2--- hr/hr_view.xml 2012-10-09 15:00:45 +0000
3+++ hr/hr_view.xml 2012-10-11 05:22:21 +0000
4@@ -334,13 +334,18 @@
5 <field name="state" widget="statusbar" statusbar_visible="recruit,open"/>
6 </header>
7 <sheet>
8- <label for="name" class="oe_edit_only"/>
9- <h1>
10- <field name="name" class="oe_inline"/>
11- <label class="oe_inline" string="(" attrs="{'invisible': [('department_id', '=', False)]}"/>
12- <field name="department_id" class="oe_inline"/>
13- <label class="oe_inline" string=")" attrs="{'invisible': [('department_id', '=', False)]}"/>
14- </h1>
15+ <div class="oe_title">
16+ <label for="name" class="oe_edit_only"/>
17+ <h1><field name="name" class="oe_inline"/></h1>
18+ </div>
19+ <div name="Department">
20+ <label for="department_id" class="oe_edit_only"/>
21+ <h1>
22+ <label class="oe_inline" string="(" attrs="{'invisible': [('department_id', '=', False)]}"/>
23+ <field name="department_id" class="oe_inline"/>
24+ <label class="oe_inline" string=")" attrs="{'invisible': [('department_id', '=', False)]}"/>
25+ </h1>
26+ </div>
27 <group>
28 <group>
29 <field name="no_of_employee" groups="base.group_user"/>
30
31=== modified file 'hr_expense/security/ir.model.access.csv'
32--- hr_expense/security/ir.model.access.csv 2012-09-20 08:56:09 +0000
33+++ hr_expense/security/ir.model.access.csv 2012-10-11 05:22:21 +0000
34@@ -9,6 +9,7 @@
35 access_product_uom_hr_expense_user,product.uom.hr.expense.user,product.model_product_uom,base.group_hr_user,1,1,1,1
36 access_product_price_type_user,product.price.type.user,product.model_product_price_type,base.group_hr_user,1,1,1,1
37 access_account_journal_user,account.journal.user,account.model_account_journal,base.group_hr_user,1,1,1,1
38+access_account_journal_employee,account.journal.employee,account.model_account_journal,base.group_user,1,1,1,1
39 access_account_invoice_user,account.invoice.user,account.model_account_invoice,base.group_hr_user,1,1,1,1
40 access_account_invoice_line_user,account.invoice.line.user,account.model_account_invoice_line,base.group_hr_user,1,1,1,1
41 access_account_analytic_journal_user,account.ianalytic.journal.user,account.model_account_analytic_journal,base.group_hr_user,1,1,1,1
42
43=== modified file 'hr_holidays/hr_holidays_view.xml'
44--- hr_holidays/hr_holidays_view.xml 2012-10-04 16:10:09 +0000
45+++ hr_holidays/hr_holidays_view.xml 2012-10-11 05:22:21 +0000
46@@ -353,6 +353,32 @@
47
48 <menuitem name="My Allocation Requests" parent="menu_open_ask_holidays" id="menu_open_allocation_holidays" action="open_allocation_holidays"/>
49
50+ <record model="ir.actions.act_window" id="request_approve_allocation">
51+ <field name="name">Allocation Requests Approve</field>
52+ <field name="res_model">hr.holidays</field>
53+ <field name="view_type">form</field>
54+ <field name="context">{'default_type': 'add', 'search_default_approve':1}</field>
55+ <field name="domain">[('type','=','add')]</field>
56+ <field name="view_id" ref="allocation_leave_new"/>
57+ <field name="search_view_id" ref="view_hr_holidays_filter"/>
58+ </record>
59+
60+ <record model="ir.actions.act_window.view" id="action_request_approve_allocation_tree">
61+ <field name="sequence" eval="1"/>
62+ <field name="view_mode">tree</field>
63+ <field name="view_id" ref="view_holiday_allocation_tree"/>
64+ <field name="act_window_id" ref="request_approve_allocation"/>
65+ </record>
66+
67+ <record model="ir.actions.act_window.view" id="action_request_approve_allocation_form">
68+ <field name="sequence" eval="2"/>
69+ <field name="view_mode">form</field>
70+ <field name="view_id" ref="allocation_leave_new"/>
71+ <field name="act_window_id" ref="request_approve_allocation"/>
72+ </record>
73+
74+ <menuitem name="Allocation Requests to Approve" parent="menu_open_ask_holidays" id="menu_request_approve_allocation" action="request_approve_allocation" groups="base.group_hr_manager"/>
75+
76 <record model="ir.actions.act_window" id="open_company_allocation">
77 <field name="name">Leaves Summary</field>
78 <field name="res_model">hr.holidays</field>
79
80=== modified file 'hr_recruitment/hr_recruitment_view.xml'
81--- hr_recruitment/hr_recruitment_view.xml 2012-10-08 10:00:32 +0000
82+++ hr_recruitment/hr_recruitment_view.xml 2012-10-11 05:22:21 +0000
83@@ -342,7 +342,7 @@
84 attrs="{'invisible':[('survey_id','=',False)]}"/>
85 </div>
86 </field>
87- <xpath expr="/form/sheet/h1" version="7.0" position="after">
88+ <xpath expr="//div[@name='Department']" version="7.0" position="after">
89 <div colspan="4" attrs="{'invisible': [('alias_domain', '=', False)]}">
90 <field name="alias_id" invisible="1" required="0"/>
91 <label for="alias_name" class="oe_edit_only"/>
92
93=== modified file 'hr_timesheet_invoice/hr_timesheet_invoice.py'
94--- hr_timesheet_invoice/hr_timesheet_invoice.py 2012-10-02 20:40:23 +0000
95+++ hr_timesheet_invoice/hr_timesheet_invoice.py 2012-10-11 05:22:21 +0000
96@@ -135,6 +135,8 @@
97 def _default_general_account(self, cr, uid, context=None):
98 proxy = self.pool.get('hr.employee')
99 record_ids = proxy.search(cr, uid, [('user_id', '=', uid)], context=context)
100+ if not record_ids:
101+ raise osv.except_osv(_('Error!'), _('Please create an employee and associate it with this user.'))
102 employee = proxy.browse(cr, uid, record_ids[0], context=context)
103 if employee.product_id and employee.product_id.property_account_income:
104 return employee.product_id.property_account_income.id
105
106=== modified file 'hr_timesheet_sheet/wizard/hr_timesheet_current.py'
107--- hr_timesheet_sheet/wizard/hr_timesheet_current.py 2012-10-02 15:15:20 +0000
108+++ hr_timesheet_sheet/wizard/hr_timesheet_current.py 2012-10-11 05:22:21 +0000
109@@ -35,7 +35,7 @@
110
111 user_ids = self.pool.get('hr.employee').search(cr, uid, [('user_id','=',uid)], context=context)
112 if not len(user_ids):
113- raise osv.except_osv(_('Error!'), _('Please define employee for your user!'))
114+ raise osv.except_osv(_('Error!'), _('Please create an employee and associate it with this user.'))
115 ids = ts.search(cr, uid, [('user_id','=',uid),('state','=','draft'),('date_from','<=',time.strftime('%Y-%m-%d')), ('date_to','>=',time.strftime('%Y-%m-%d'))], context=context)
116
117 if len(ids) > 1:

Subscribers

People subscribed via source and target branches

to all changes: