Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/trunk-addons20_project-ssu into lp:openobject-addons

  1. trunk-addons20_project-ssu
  2. Merge into trunk
Proposed by Saurang Suthar(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-addons20_project-ssu
Merge into: lp:openobject-addons
Diff against target: 12 lines (+2/-0)
1 file modified
analytic/analytic.py (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-addons20_project-ssu
Reviewer Review Type Date Requested Status
Ajay Patel (OpenERP) (community) Approve
Review via email: mp+133027@code.launchpad.net

Description of the change

Hello sir,

I have resolved the traceback while clicking on Timesheet link from project kanban/form view.

Kindly review it.

Thank you.
Saurang Suthar

To post a comment you must log in.
Revision history for this message
Ajay Patel (OpenERP) (ajay-openerp) wrote :

Hello ,

Thanks to quick fix.

if isinstance(ids, (int, long)):
    ids = [ids]

remove ',' from list.

Thanks,
Amit

review: Needs Fixing
Reply
lp:~openerp-dev/openobject-addons/trunk-addons20_project-ssu updated
7955. By Saurang Suthar(OpenERP)

[IMP]analytic:done changes as per suggestion

Revision history for this message
Ajay Patel (OpenERP) (ajay-openerp) :
review: Approve
Reply

Unmerged revisions

7955. By Saurang Suthar(OpenERP)

[IMP]analytic:done changes as per suggestion

7954. By Saurang Suthar(OpenERP)

[IMP]analytic:resolved the traceback click on Timesheets link from project kanban/form view

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'analytic/analytic.py'
2--- analytic/analytic.py 2012-11-02 16:16:29 +0000
3+++ analytic/analytic.py 2012-11-06 12:34:22 +0000
4@@ -98,6 +98,8 @@
5
6 def name_get(self, cr, uid, ids, context=None):
7 res = []
8+ if isinstance(ids, (int, long)):
9+ ids = [ids]
10 for id in ids:
11 elmt = self.browse(cr, uid, id, context=context)
12 res.append((id, self._get_one_full_name(elmt)))

Subscribers

People subscribed via source and target branches

to all changes: