Merge lp:~openerp-dev/openobject-addons/trunk-account-installer-wizard-pza into lp:openobject-addons
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-dev/openobject-addons/trunk-account-installer-wizard-pza |
Merge into: | lp:openobject-addons |
Diff against target: |
272 lines (+139/-5) 7 files modified
account/account.py (+11/-0) account/account_installer.xml (+2/-0) account/installer.py (+36/-1) account/partner.py (+18/-2) account/partner_view.xml (+8/-0) account/product.py (+48/-2) account/product_view.xml (+16/-0) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/trunk-account-installer-wizard-pza |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mustufa Rangwala (Open ERP) (community) | Needs Fixing | ||
Thibault Delavallée (OpenERP) | Pending | ||
Review via email: mp+204842@code.launchpad.net |
This proposal supersedes a proposal from 2013-11-22.
Description of the change
Hello,
I have update the code as per your suggestion.
=> (_next override): if i test without that code, below test case does not work properly.
Steps for test case:
1 Create another company “Demo Company”.
2 Create new user “Demo User” and set the company of user “Demo company”.
3 Provide appropriate rights and login with this user.
Go to Accounting -> Customers -> Customers menu and click on Create button to create a new customer. You will find a warning message above customer
Now, To configure accounting chart and taxes click on link appear on message “Setup Accounting Information”. It will open "Configure Accounting Data" wizard after click on continue on this wizard next wizard("Set Your Accounting Options") for set accounting option will not pop up if we remove that code and it redirects to customer and also give that warning again.
Thanks.
Jitendra(JPR)
Unmerged revisions
- 8995. By Randhir Mayatra (OpenERP)
-
[IMP] update open_account_
installer method - 8994. By Randhir Mayatra (OpenERP)
-
[MERGE] merge with latest trunk
- 8993. By Randhir Mayatra (OpenERP)
-
[IMP] imorived company_id domain
- 8992. By Randhir Mayatra (OpenERP)
-
[MERGE] merge with latest trunk
- 8991. By Randhir Mayatra (OpenERP)
-
[IMP] improved search methods
- 8990. By Randhir Mayatra (OpenERP)
-
[IMP] optimize code
- 8989. By Randhir Mayatra (OpenERP)
-
[MERGE] merge with latest trunk
- 8988. By Randhir Mayatra (OpenERP)
-
[IMP] improve warning message as per the user access right
- 8987. By Randhir Mayatra (OpenERP)
-
[IMP] improve help string
- 8986. By Randhir Mayatra (OpenERP)
-
[MERGE] merge with latest trunk
Hello,
In account/ installer. py: I don't see the point with the _next override. When removing this code, everything seems to work fine. Please confirm that this code is not necessary and remove it.
In account/partner.py: coa_configured: simplifty code using return bool(prop_ids)
- _check_
In account/ partner_ view.py:
- next_action does not seem necessary; introduce a key 'reload_page' replacing next action, and handle it in account/account.py, in _next.
In account/account.py:
- probably replace next_action by reload_page
- context.get returns None by default: no need to use if context.get(key, False) -> if context.get(key)
- instead of updating context, simply remove the key from context (context.pop(key))