Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/saas-3-removed-domain-warning-mme into lp:~openerp/openobject-addons/saas-3

Proposed by Mehul Mehta(OpenERP) on 2014-03-21

Status:	Needs review
Proposed branch:	lp:~openerp-dev/openobject-addons/saas-3-removed-domain-warning-mme
Merge into:	lp:~openerp/openobject-addons/saas-3
Diff against target:	12 lines (+1/-1) 1 file modified sale_crm/sale_crm.py (+1/-1)
To merge this branch:	bzr merge lp:~openerp-dev/openobject-addons/saas-3-removed-domain-warning-mme
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
OpenERP Core Team		2014-03-21	Pending
Review via email: mp+212093@code.launchpad.net

Hello,

Resolved the Warning
[Warning] The domain term '('state', '=', ['draft'])' should use the 'in' or 'not in' operator.

Thanks,
Mehul Mehta(mme)

9331. By Mehul Mehta(OpenERP) on 2014-03-20: [FIX] Warning: The domain term '('state', '=', ['draft'])' should use

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'sale_crm/sale_crm.py'
2	--- sale_crm/sale_crm.py 2013-12-18 15:57:15 +0000
3	+++ sale_crm/sale_crm.py 2014-03-21 06:34:34 +0000
4	@@ -76,7 +76,7 @@
5	date_end = month_begin.replace(day=calendar.monthrange(month_begin.year, month_begin.month)[1]).strftime(tools.DEFAULT_SERVER_DATE_FORMAT)
6	for id in ids:
7	res[id] = dict()
8	- created_domain = [('section_id', '=', id), ('state', '=', ['draft']), ('date_order', '>=', date_begin), ('date_order', '<=', date_end)]
9	+ created_domain = [('section_id', '=', id), ('state', '=', 'draft'), ('date_order', '>=', date_begin), ('date_order', '<=', date_end)]
10	res[id]['monthly_quoted'] = self.__get_bar_values(cr, uid, obj, created_domain, ['amount_total', 'date_order'], 'amount_total', 'date_order', context=context)
11	validated_domain = [('section_id', '=', id), ('state', 'not in', ['draft', 'sent', 'cancel']), ('date_order', '>=', date_begin), ('date_order', '<=', date_end)]
12	res[id]['monthly_confirmed'] = self.__get_bar_values(cr, uid, obj, validated_domain, ['amount_total', 'date_order'], 'amount_total', 'date_order', context=context)